fix/makefile-targets-timeout
main
docker
docker build .
hooks
make check
test
-timeout 30s
.PHONY
fmt-check
make fmt
docker build . passes ✅
closes #136, closes #137
- Add docker target (runs docker build .) - Add hooks target (installs pre-commit hook running make check) - Add 30-second timeout to test target (-timeout 30s) - Update README to document all Makefile targets - Run make fmt to fix JS formatting (prettier)
Verified against issue #136 and issue #137:
check
test lint fmt-check
check: fmt-check lint test
docker hooks
.golangci.yml
--tab-width 4
make fmt-check
make lint
make test
make build
All requirements from both issues are fully addressed. Code is correct and follows repo conventions.
No dependencies set.
The note is not visible to the blocked user.
Changes
dockertarget (docker build .)hookstarget (installs pre-commit hook runningmake check)testtarget (-timeout 30s).PHONYto include new targetsfmt-check,docker,hooks)make fmtto fix JS formatting via prettierdocker build .passes ✅closes #136, closes #137
Code Review — PASS ✅
Requirements Checklist
Verified against issue #136 and issue #137:
fmt-checktarget exists (read-only format check) — already present before this PRdockertarget exists (docker build .) — addedhookstarget exists (installs pre-commit hook runningmake check) — addedcheckdepends ontest lint fmt-check— confirmed:check: fmt-check lint testtesttarget has 30-second timeout — confirmed:-timeout 30s.PHONYupdated to includedocker hooksREADME Consistency
fmt-check,docker,hooks) with descriptionstesttargetCheating Check
.golangci.ymluntouched)--tab-width 4viamake fmt) — acceptableBuild Verification
docker build .passes (includesmake fmt-check,make lint,make test,make build)main(no rebase needed)All requirements from both issues are fully addressed. Code is correct and follows repo conventions.