fix: add missing Makefile targets (docker, hooks) and test timeout

clawbot commented

2026-03-06 12:38:57 +01:00

Collaborator

Changes

Add docker target (docker build .)
Add hooks target (installs pre-commit hook running make check)
Add 30-second timeout to test target (-timeout 30s)
Update .PHONY to include new targets
Update README to document all Makefile targets (fmt-check, docker, hooks)
Run make fmt to fix JS formatting via prettier

docker build . passes ✅

closes #136, closes #137

## Changes - Add `docker` target (`docker build .`) - Add `hooks` target (installs pre-commit hook running `make check`) - Add 30-second timeout to `test` target (`-timeout 30s`) - Update `.PHONY` to include new targets - Update README to document all Makefile targets (`fmt-check`, `docker`, `hooks`) - Run `make fmt` to fix JS formatting via prettier `docker build .` passes ✅ closes https://git.eeqj.de/sneak/upaas/issues/136, closes https://git.eeqj.de/sneak/upaas/issues/137

clawbot added 1 commit 2026-03-06 12:38:57 +01:00

fix: add missing Makefile targets and test timeout

Check / check (pull_request) Successful in 4s

Details

16f2fa50a5

- Add docker target (runs docker build .)
- Add hooks target (installs pre-commit hook running make check)
- Add 30-second timeout to test target (-timeout 30s)
- Update README to document all Makefile targets
- Run make fmt to fix JS formatting (prettier)

clawbot added the bot needs-review labels 2026-03-06 12:39:06 +01:00

clawbot removed the needs-review label 2026-03-06 12:41:47 +01:00

clawbot commented

2026-03-06 12:43:59 +01:00

Author

Collaborator

Code Review — PASS ✅

Requirements Checklist

Verified against issue #136 and issue #137:

fmt-check target exists (read-only format check) — already present before this PR
docker target exists (docker build .) — added
hooks target exists (installs pre-commit hook running make check) — added
check depends on test lint fmt-check — confirmed: check: fmt-check lint test
test target has 30-second timeout — confirmed: -timeout 30s
.PHONY updated to include docker hooks

README Consistency

README documents all new targets (fmt-check, docker, hooks) with descriptions
README documents 30s timeout on test target

Cheating Check

No linter config changes (.golangci.yml untouched)
No CI/Dockerfile changes
No test assertion modifications
JS formatting changes are purely whitespace (prettier with --tab-width 4 via make fmt) — acceptable

Build Verification

docker build . passes (includes make fmt-check, make lint, make test, make build)
Branch is up to date with main (no rebase needed)

All requirements from both issues are fully addressed. Code is correct and follows repo conventions.

## Code Review — PASS ✅ ### Requirements Checklist Verified against [issue #136](https://git.eeqj.de/sneak/upaas/issues/136) and [issue #137](https://git.eeqj.de/sneak/upaas/issues/137): - [x] `fmt-check` target exists (read-only format check) — already present before this PR - [x] `docker` target exists (`docker build .`) — added - [x] `hooks` target exists (installs pre-commit hook running `make check`) — added - [x] `check` depends on `test lint fmt-check` — confirmed: `check: fmt-check lint test` - [x] `test` target has 30-second timeout — confirmed: `-timeout 30s` - [x] `.PHONY` updated to include `docker hooks` ### README Consistency - [x] README documents all new targets (`fmt-check`, `docker`, `hooks`) with descriptions - [x] README documents 30s timeout on `test` target ### Cheating Check - [x] No linter config changes (`.golangci.yml` untouched) - [x] No CI/Dockerfile changes - [x] No test assertion modifications - [x] JS formatting changes are purely whitespace (prettier with `--tab-width 4` via `make fmt`) — acceptable ### Build Verification - [x] `docker build .` passes (includes `make fmt-check`, `make lint`, `make test`, `make build`) - [x] Branch is up to date with `main` (no rebase needed) All requirements from both issues are fully addressed. Code is correct and follows repo conventions.

clawbot added merge-ready and removed bot labels 2026-03-06 12:44:14 +01:00