Refactor: break up app.js into smaller modules #129

clawbot · 2026-02-23T20:52:52+01:00

clawbot commented

2026-02-23 20:52:52 +01:00

Closes #128

Splits static/js/app.js (581 lines) into 5 focused modules:

utils.js — global utilities store + legacy compat
components.js — reusable Alpine.js components (copy, confirm, dismiss, time)
app-detail.js — app detail page logic (status polling, logs)
deployment.js — deployment card + deployments history page
dashboard.js — dashboard relative time updates

All loaded via separate <script> tags in base.html (utils first, then others).

make check passes cleanly.

Closes #128 Splits `static/js/app.js` (581 lines) into 5 focused modules: - **utils.js** — global utilities store + legacy compat - **components.js** — reusable Alpine.js components (copy, confirm, dismiss, time) - **app-detail.js** — app detail page logic (status polling, logs) - **deployment.js** — deployment card + deployments history page - **dashboard.js** — dashboard relative time updates All loaded via separate `<script>` tags in `base.html` (utils first, then others). `make check` passes cleanly.

sneak was assigned by clawbot

2026-02-23 20:52:52 +01:00

clawbot added 1 commit 2026-02-23 20:52:53 +01:00

refactor: break up app.js into smaller modules

Check / check (pull_request) Successful in 11m29s

Details

5fe11f24d4

Split static/js/app.js (581 lines) into 5 focused modules:
- utils.js: global utilities store + legacy compat
- components.js: reusable Alpine.js components (copy, confirm, dismiss, time)
- app-detail.js: app detail page logic (status polling, logs)
- deployment.js: deployment card + deployments history page
- dashboard.js: dashboard relative time updates

Closes #128

clawbot added the

needs-checks

label 2026-02-24 00:42:58 +01:00

clawbot added

merge-ready

and removed

needs-checks

labels 2026-02-24 00:44:16 +01:00

clawbot commented

2026-02-24 00:44:18 +01:00

`make check` output

All tests passed:
- git.eeqj.de/sneak/upaas/internal/models: PASS (3.773s)
- git.eeqj.de/sneak/upaas/internal/service/app: PASS (2.880s)
- git.eeqj.de/sneak/upaas/internal/service/auth: PASS (3.149s)
- git.eeqj.de/sneak/upaas/internal/service/deploy: PASS (2.237s)
- git.eeqj.de/sneak/upaas/internal/service/webhook: PASS (3.117s)
- git.eeqj.de/sneak/upaas/internal/ssh: PASS (3.955s)
- Build: OK

==> All checks passed!

Code Review: Clean refactor splitting monolithic app.js (581 lines) into 5 focused modules (utils.js, components.js, app-detail.js, deployment.js, dashboard.js). No logic changes, just reorganization. Template updated to load all modules. LGTM ✅

## `make check` output ``` All tests passed: - git.eeqj.de/sneak/upaas/internal/models: PASS (3.773s) - git.eeqj.de/sneak/upaas/internal/service/app: PASS (2.880s) - git.eeqj.de/sneak/upaas/internal/service/auth: PASS (3.149s) - git.eeqj.de/sneak/upaas/internal/service/deploy: PASS (2.237s) - git.eeqj.de/sneak/upaas/internal/service/webhook: PASS (3.117s) - git.eeqj.de/sneak/upaas/internal/ssh: PASS (3.955s) - Build: OK ==> All checks passed! ``` **Code Review:** Clean refactor splitting monolithic `app.js` (581 lines) into 5 focused modules (`utils.js`, `components.js`, `app-detail.js`, `deployment.js`, `dashboard.js`). No logic changes, just reorganization. Template updated to load all modules. LGTM ✅