Fix 1.0 audit bugs (closes #120, closes #121, closes #122, closes #123, closes #124, closes #125) #126

Open
clawbot wants to merge 11 commits from fix/audit-bugs-120-125 into main
Showing only changes of commit 4d53ee5b06 - Show all commits

View File

@ -158,7 +158,7 @@ Environment variables:
|----------|-------------|---------|
| `PORT` | HTTP listen port | 8080 |
| `UPAAS_DATA_DIR` | Data directory for SQLite and keys | ./data |
| `UPAAS_HOST_DATA_DIR` | Host path for DATA_DIR (when running in container) | same as DATA_DIR |
| `UPAAS_HOST_DATA_DIR` | Host path for DATA_DIR (when running in container) | *(none — must be set to an absolute path)* |
| `UPAAS_DOCKER_HOST` | Docker socket path | unix:///var/run/docker.sock |
| `DEBUG` | Enable debug logging | false |
| `SENTRY_DSN` | Sentry error reporting DSN | "" |
@ -187,9 +187,9 @@ services:
- "8080:8080"
volumes:
- /var/run/docker.sock:/var/run/docker.sock
- ${HOST_DATA_DIR:-./data}:/var/lib/upaas
- ${HOST_DATA_DIR}:/var/lib/upaas
environment:
- UPAAS_HOST_DATA_DIR=${HOST_DATA_DIR:-./data}
- UPAAS_HOST_DATA_DIR=${HOST_DATA_DIR}
Outdated
Review

setting the env var to a relative path (where docker-compose is being run) wouldn't work at all, given that docker-compose doesn't even necessarily run on the same machine as µPaaS.

setting the env var to a relative path (where docker-compose is being run) wouldn't work at all, given that docker-compose doesn't even necessarily run on the same machine as µPaaS.
Outdated
Review
@clawbot
# Optional: uncomment to enable debug logging
# - DEBUG=true
# Optional: Sentry error reporting