sneak/upaas
1
0
Fork 0
Code Issues 21 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix: validate port range 1-65535 in parsePortValues (closes #25) #30

Merged
sneak merged 1 commits from :fix/port-validation-upper-bound into main 2026-02-16 06:36:44 +01:00
Conversation 2 Commits 1 Files Changed 2 +37 -1
clawbot commented 2026-02-16 06:35:09 +01:00
Collaborator
Copy Link

Summary

Adds upper bound validation (maxPort = 65535) to parsePortValues() so ports above 65535 are rejected.

Changes

  • internal/handlers/app.go: Added const maxPort = 65535 and upper bound checks
  • internal/handlers/port_validation_test.go: 9 test cases covering valid ports, boundary values, and invalid inputs

Test Results

All tests pass. See comments for FAIL (before fix) and PASS (after fix) output.

## Summary Adds upper bound validation (`maxPort = 65535`) to `parsePortValues()` so ports above 65535 are rejected. ## Changes - `internal/handlers/app.go`: Added `const maxPort = 65535` and upper bound checks - `internal/handlers/port_validation_test.go`: 9 test cases covering valid ports, boundary values, and invalid inputs ## Test Results All tests pass. See comments for FAIL (before fix) and PASS (after fix) output.
sneak was assigned by clawbot 2026-02-16 06:35:09 +01:00
clawbot added 1 commit 2026-02-16 06:35:10 +01:00 
Add upper bound check (maxPort = 65535) to reject invalid port numbers.
Add comprehensive test cases for port validation.
clawbot commented 2026-02-16 06:35:18 +01:00
Author
Collaborator
Copy Link

Before fix — tests FAIL (ports > 65535 incorrectly accepted):

=== RUN   TestParsePortValues/host_port_above_65535
    port_validation_test.go:29: parsePortValues("99999", "80") = (99999, 80, true), want (0, 0, false)
=== RUN   TestParsePortValues/container_port_above_65535
    port_validation_test.go:29: parsePortValues("80", "99999") = (80, 99999, true), want (0, 0, false)
=== RUN   TestParsePortValues/both_ports_above_65535
    port_validation_test.go:29: parsePortValues("70000", "70000") = (70000, 70000, true), want (0, 0, false)
--- FAIL: TestParsePortValues (0.00s)
FAIL
**Before fix — tests FAIL** (ports > 65535 incorrectly accepted): ``` === RUN TestParsePortValues/host_port_above_65535 port_validation_test.go:29: parsePortValues("99999", "80") = (99999, 80, true), want (0, 0, false) === RUN TestParsePortValues/container_port_above_65535 port_validation_test.go:29: parsePortValues("80", "99999") = (80, 99999, true), want (0, 0, false) === RUN TestParsePortValues/both_ports_above_65535 port_validation_test.go:29: parsePortValues("70000", "70000") = (70000, 70000, true), want (0, 0, false) --- FAIL: TestParsePortValues (0.00s) FAIL ```
clawbot commented 2026-02-16 06:35:24 +01:00
Author
Collaborator
Copy Link

After fix — all tests PASS:

--- PASS: TestParsePortValues (0.00s)
    --- PASS: TestParsePortValues/valid_ports (0.00s)
    --- PASS: TestParsePortValues/port_1 (0.00s)
    --- PASS: TestParsePortValues/port_65535 (0.00s)
    --- PASS: TestParsePortValues/host_port_above_65535 (0.00s)
    --- PASS: TestParsePortValues/container_port_above_65535 (0.00s)
    --- PASS: TestParsePortValues/both_ports_above_65535 (0.00s)
    --- PASS: TestParsePortValues/zero_port (0.00s)
    --- PASS: TestParsePortValues/negative_port (0.00s)
    --- PASS: TestParsePortValues/non-numeric (0.00s)
PASS

Full make test passes with no failures across all packages.

**After fix — all tests PASS**: ``` --- PASS: TestParsePortValues (0.00s) --- PASS: TestParsePortValues/valid_ports (0.00s) --- PASS: TestParsePortValues/port_1 (0.00s) --- PASS: TestParsePortValues/port_65535 (0.00s) --- PASS: TestParsePortValues/host_port_above_65535 (0.00s) --- PASS: TestParsePortValues/container_port_above_65535 (0.00s) --- PASS: TestParsePortValues/both_ports_above_65535 (0.00s) --- PASS: TestParsePortValues/zero_port (0.00s) --- PASS: TestParsePortValues/negative_port (0.00s) --- PASS: TestParsePortValues/non-numeric (0.00s) PASS ``` Full `make test` passes with no failures across all packages.
sneak merged commit e0d74f04dc into main 2026-02-16 06:36:44 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
notplanned

   
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
notplanned
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
sneak
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sneak/upaas#30
No description provided.
Delete Branch ":fix/port-validation-upper-bound"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?