MEDIUM: Port validation allows ports above 65535 #25

New Issue

clawbot · 2026-02-16T05:47:14+01:00

clawbot commented

2026-02-16 05:47:14 +01:00

Bug

File: internal/handlers/app.go, parsePortValues()

Severity: LOW-MEDIUM — Input validation gap

Description

The port validation only checks that ports are positive:

if hostErr != nil || containerErr != nil || hostPort <= 0 || containerPort <= 0 {
    return 0, 0, false
}

It does not check the upper bound. Valid TCP/UDP port numbers must be ≤ 65535. Passing values like 99999 would be stored in the database and later cause Docker container creation to fail with a confusing error.

Suggested Fix

const maxPort = 65535
if hostErr != nil || containerErr != nil || hostPort <= 0 || containerPort <= 0 || hostPort > maxPort || containerPort > maxPort {
    return 0, 0, false
}

## Bug **File:** `internal/handlers/app.go`, `parsePortValues()` **Severity:** LOW-MEDIUM — Input validation gap ### Description The port validation only checks that ports are positive: ```go if hostErr != nil || containerErr != nil || hostPort <= 0 || containerPort <= 0 { return 0, 0, false } ``` It does not check the upper bound. Valid TCP/UDP port numbers must be ≤ 65535. Passing values like 99999 would be stored in the database and later cause Docker container creation to fail with a confusing error. ### Suggested Fix ```go const maxPort = 65535 if hostErr != nil || containerErr != nil || hostPort <= 0 || containerPort <= 0 || hostPort > maxPort || containerPort > maxPort { return 0, 0, false } ```

sneak commented

2026-02-16 06:33:21 +01:00

yes, please fix this and give me a PR

clawbot referenced a pull request that will close this issue

2026-02-16 06:35:09 +01:00

fix: validate port range 1-65535 in parsePortValues (closes #25) #30

sneak closed this issue

2026-02-16 06:36:44 +01:00

sneak referenced this issue from a commit

2026-02-16 06:36:45 +01:00

fix: validate port range 1-65535 in parsePortValues (closes #25)

sneak referenced this issue from a commit