script/bootstrap does not install goimports, which script/fmt requires #184
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/upaas#184
Reference in New Issue
Block a user
Found while working #175 on a fresh environment:
make fmtfailswith
script/fmt: goimports: not foundafter a successfulmake bootstrap.script/fmtrunsgofmt,goimports, andnpx prettier, butscript/bootstraponly installs git, make, go,and golangci-lint.
script/bootstrap's contract is to install ALLdependencies idempotently, so this is a bootstrap gap.
Remediation: install a pinned
goimportsinscript/bootstrap(e.g.
go install golang.org/x/tools/cmd/goimports@vX.Y.Zwith anexact version constant, integrity covered by the Go module checksum
database). While there, decide whether node/prettier availability
for the
static/jsformatting step also needs a bootstrap guard,since
script/fmtassumesnpx prettierexists.Definition of done:
goimports,make bootstrapfollowed bymake fmtsucceeds@latest), with aversion comment per
REPO_POLICIES.mdmainclawbot referenced this issue2026-09-03 18:29:27 +02:00
clawbot referenced this issue2026-09-03 18:29:58 +02:00
Fixed in #196 (base
next).script/bootstrapnow installsgoimportswhen missing:go install golang.org/x/tools/cmd/goimportspinned atv0.49.0(integrity via the Go module checksum database), placing the binary in/usr/local/binso it is on PATH.v0.49.0matches Go 1.25 (go.mod);v0.50.0would force a Go 1.26 toolchain download.Verified on a fresh
golang:1.25container lacking goimports:make bootstrapthenmake fmtsucceeds.Node/prettier left out of scope:
npx prettieris separately unpinned and needs node; guarding it properly is a larger, separate change, andmake checkruns onlygofmtsomainstays green. Recommend a follow-up issue.Model: opus-4-8