sneak/upaas
1
0
Fork 1
Code Issues 8 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

lint: fix all 47 noctx findings (httptest.NewRequest without context) #175

New Issue
Closed
opened 2026-08-07 18:40:22 +02:00 by clawbot · 3 comments
clawbot commented 2026-08-07 18:40:22 +02:00
Collaborator
Copy Link

Surveyed 2026-08-07: make check on main fails with 94 lint findings
under golangci-lint 2.12.2 (the version installed for local dev). 47 of
them are noctx, all of the same shape: test code calling
httptest.NewRequest instead of httptest.NewRequestWithContext.

Note: CI is currently green because the Dockerfile lint stage pins
golangci-lint v2.10.1, which does not report these. The findings are
real under the current linter and block a locally green make check;
CI parity is tracked separately (bump of the lint stage pin).

All 47 findings are in test files:

File Findings
internal/handlers/handlers_test.go 26
internal/middleware/ratelimit_test.go 7
internal/handlers/api_test.go 6
internal/middleware/cors_test.go 3
internal/handlers/render_template_test.go 3
internal/service/auth/auth_test.go 2

Remediation: replace each httptest.NewRequest(...) with
httptest.NewRequestWithContext(t.Context(), ...) (or the enclosing
test's context where a subtest closure already has one). Purely
mechanical; no production code changes.

Definition of done:

  • make lint (golangci-lint ≥ 2.12) reports zero noctx findings
  • total finding count drops from 94 to 47
  • make test passes unchanged; make fmt run before commit
  • TODO.md updated per the repo workflow (this is the current "Next
    Step" there)
  • lands via PR from a feature branch off main
Surveyed 2026-08-07: `make check` on `main` fails with 94 lint findings under golangci-lint 2.12.2 (the version installed for local dev). 47 of them are `noctx`, all of the same shape: test code calling `httptest.NewRequest` instead of `httptest.NewRequestWithContext`. Note: CI is currently green because the `Dockerfile` lint stage pins golangci-lint v2.10.1, which does not report these. The findings are real under the current linter and block a locally green `make check`; CI parity is tracked separately (bump of the lint stage pin). All 47 findings are in test files: | File | Findings | | --- | --- | | `internal/handlers/handlers_test.go` | 26 | | `internal/middleware/ratelimit_test.go` | 7 | | `internal/handlers/api_test.go` | 6 | | `internal/middleware/cors_test.go` | 3 | | `internal/handlers/render_template_test.go` | 3 | | `internal/service/auth/auth_test.go` | 2 | Remediation: replace each `httptest.NewRequest(...)` with `httptest.NewRequestWithContext(t.Context(), ...)` (or the enclosing test's context where a subtest closure already has one). Purely mechanical; no production code changes. Definition of done: - `make lint` (golangci-lint ≥ 2.12) reports zero `noctx` findings - total finding count drops from 94 to 47 - `make test` passes unchanged; `make fmt` run before commit - `TODO.md` updated per the repo workflow (this is the current "Next Step" there) - lands via PR from a feature branch off `main`
clawbot added this to the 1.1.0 milestone 2026-08-07 18:40:22 +02:00
clawbot commented 2026-08-07 18:41:48 +02:00
Author
Collaborator
Copy Link

Starting this now on a branch off current main (291f85f).

Definition of done for the PR:

  • all 47 noctx findings gone: every httptest.NewRequest call in
    the six listed test files becomes
    httptest.NewRequestWithContext(t.Context(), ...) (using the
    enclosing test's *testing.T)
  • make lint under golangci-lint 2.12.2: total findings drop from 94
    to 47 (remaining: 23 gosec → #176/#177, 24 goconst → #178)
  • make test still green, make fmt run before commit, TODO.md
    Next Step rotated per the repo workflow
  • before/after lint counts stated on the PR
Starting this now on a branch off current `main` (291f85f). Definition of done for the PR: - all 47 `noctx` findings gone: every `httptest.NewRequest` call in the six listed test files becomes `httptest.NewRequestWithContext(t.Context(), ...)` (using the enclosing test's `*testing.T`) - `make lint` under golangci-lint 2.12.2: total findings drop from 94 to 47 (remaining: 23 `gosec` → #176/#177, 24 `goconst` → #178) - `make test` still green, `make fmt` run before commit, `TODO.md` Next Step rotated per the repo workflow - before/after lint counts stated on the PR
clawbot commented 2026-08-07 18:47:55 +02:00
Author
Collaborator
Copy Link

Done in PR #183 (branch fix-noctx-lint, commit 2164290): all 47
noctx findings resolved, make lint total 94 → 47, make test and
make fmt-check green. Awaiting independent review (labeled
needs-review).

Done in PR #183 (branch `fix-noctx-lint`, commit 2164290): all 47 `noctx` findings resolved, `make lint` total 94 → 47, `make test` and `make fmt-check` green. Awaiting independent review (labeled needs-review).
clawbot commented 2026-08-07 22:27:15 +02:00
Author
Collaborator
Copy Link

Definition of done verified met on main (7a34fc9) — the fix landed
via #187 rather than PR #183, which is now closed as superseded:

  • make lint (pinned golangci-lint v2.12.2, canonical config): 0
    findings, so zero noctx
  • every test-file request is httptest.NewRequestWithContext with
    t.Context(); grep over the main tree finds no remaining
    context-less httptest.NewRequest( call sites
  • make check green in a clean worktree of main (tests with race
    detector, lint, fmt-check)

Closing.

Definition of done verified met on `main` (7a34fc9) — the fix landed via #187 rather than PR #183, which is now closed as superseded: - `make lint` (pinned golangci-lint v2.12.2, canonical config): 0 findings, so zero `noctx` - every test-file request is `httptest.NewRequestWithContext` with `t.Context()`; grep over the `main` tree finds no remaining context-less `httptest.NewRequest(` call sites - `make check` green in a clean worktree of `main` (tests with race detector, lint, `fmt-check`) Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone 1.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#175
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?