sneak/upaas
1
0
Fork 1
Code Issues 8 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Verify branch protection on main requires the Check workflow before merge #180

New Issue
Open
opened 2026-08-07 18:41:07 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-07 18:41:07 +02:00
Collaborator
Copy Link

main is protected and .gitea/workflows/check.yml runs
script/cibuild (docker build, which runs make check) on every push
and pull request targeting main. What has not been verified is
whether the branch protection rule actually lists the Check job as a
required status check — i.e. whether a PR with a red build is blocked
from merging, or merely decorated.

TODO.md calls this out under Future Steps: "Confirm
.gitea/workflows/check.yml gates merges on make check so main cannot
regress."

Steps:

  • inspect the branch protection settings for main in the Gitea repo
    settings (requires repo admin)
  • if status-check enforcement is off, enable it and add the check
    job of the Check workflow to the required checks list
  • verify empirically: open a PR (any open lint-fix PR works), confirm
    the merge button is blocked until the workflow passes

Definition of done:

  • branch protection for main requires the Check workflow to pass
    before merge
  • verified on a real PR (screenshot or comment noting the observed
    blocked/unblocked state)
  • outcome recorded in a comment on this issue
`main` is protected and `.gitea/workflows/check.yml` runs `script/cibuild` (docker build, which runs `make check`) on every push and pull request targeting `main`. What has not been verified is whether the branch protection rule actually lists the `Check` job as a required status check — i.e. whether a PR with a red build is blocked from merging, or merely decorated. `TODO.md` calls this out under Future Steps: "Confirm `.gitea/workflows/check.yml` gates merges on make check so main cannot regress." Steps: - inspect the branch protection settings for `main` in the Gitea repo settings (requires repo admin) - if status-check enforcement is off, enable it and add the `check` job of the `Check` workflow to the required checks list - verify empirically: open a PR (any open lint-fix PR works), confirm the merge button is blocked until the workflow passes Definition of done: - branch protection for `main` requires the `Check` workflow to pass before merge - verified on a real PR (screenshot or comment noting the observed blocked/unblocked state) - outcome recorded in a comment on this issue
clawbot added this to the 1.1.0 milestone 2026-08-07 18:41:07 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone 1.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#180
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?