sneak/upaas
1
0
Fork 0
Code Issues 10 Pull Requests 3 Actions Packages Projects Releases 1 Wiki Activity

Refactor: break up app.js into smaller modules #129

Merged
sneak merged 1 commits from refactor/split-app-js into main 2026-02-26 10:59:03 +01:00
Conversation 1 Commits 1 Files Changed 7 +610 -582
clawbot commented 2026-02-23 20:52:52 +01:00
Collaborator
Copy Link

Closes #128

Splits static/js/app.js (581 lines) into 5 focused modules:

  • utils.js — global utilities store + legacy compat
  • components.js — reusable Alpine.js components (copy, confirm, dismiss, time)
  • app-detail.js — app detail page logic (status polling, logs)
  • deployment.js — deployment card + deployments history page
  • dashboard.js — dashboard relative time updates

All loaded via separate <script> tags in base.html (utils first, then others).

make check passes cleanly.

Closes #128 Splits `static/js/app.js` (581 lines) into 5 focused modules: - **utils.js** — global utilities store + legacy compat - **components.js** — reusable Alpine.js components (copy, confirm, dismiss, time) - **app-detail.js** — app detail page logic (status polling, logs) - **deployment.js** — deployment card + deployments history page - **dashboard.js** — dashboard relative time updates All loaded via separate `<script>` tags in `base.html` (utils first, then others). `make check` passes cleanly.
sneak was assigned by clawbot 2026-02-23 20:52:52 +01:00
clawbot added 1 commit 2026-02-23 20:52:53 +01:00
refactor: break up app.js into smaller modules
All checks were successful
Check / check (pull_request) Successful in 11m29s
Details
5fe11f24d4 
Split static/js/app.js (581 lines) into 5 focused modules:
- utils.js: global utilities store + legacy compat
- components.js: reusable Alpine.js components (copy, confirm, dismiss, time)
- app-detail.js: app detail page logic (status polling, logs)
- deployment.js: deployment card + deployments history page
- dashboard.js: dashboard relative time updates

Closes #128
clawbot added the needs-checks label 2026-02-24 00:42:58 +01:00
clawbot added merge-ready and removed needs-checks labels 2026-02-24 00:44:16 +01:00
clawbot commented 2026-02-24 00:44:18 +01:00
Author
Collaborator
Copy Link

make check output

All tests passed:
- git.eeqj.de/sneak/upaas/internal/models: PASS (3.773s)
- git.eeqj.de/sneak/upaas/internal/service/app: PASS (2.880s)
- git.eeqj.de/sneak/upaas/internal/service/auth: PASS (3.149s)
- git.eeqj.de/sneak/upaas/internal/service/deploy: PASS (2.237s)
- git.eeqj.de/sneak/upaas/internal/service/webhook: PASS (3.117s)
- git.eeqj.de/sneak/upaas/internal/ssh: PASS (3.955s)
- Build: OK

==> All checks passed!

Code Review: Clean refactor splitting monolithic app.js (581 lines) into 5 focused modules (utils.js, components.js, app-detail.js, deployment.js, dashboard.js). No logic changes, just reorganization. Template updated to load all modules. LGTM ✅

## `make check` output ``` All tests passed: - git.eeqj.de/sneak/upaas/internal/models: PASS (3.773s) - git.eeqj.de/sneak/upaas/internal/service/app: PASS (2.880s) - git.eeqj.de/sneak/upaas/internal/service/auth: PASS (3.149s) - git.eeqj.de/sneak/upaas/internal/service/deploy: PASS (2.237s) - git.eeqj.de/sneak/upaas/internal/service/webhook: PASS (3.117s) - git.eeqj.de/sneak/upaas/internal/ssh: PASS (3.955s) - Build: OK ==> All checks passed! ``` **Code Review:** Clean refactor splitting monolithic `app.js` (581 lines) into 5 focused modules (`utils.js`, `components.js`, `app-detail.js`, `deployment.js`, `dashboard.js`). No logic changes, just reorganization. Template updated to load all modules. LGTM ✅
sneak merged commit e051245b5f into main 2026-02-26 10:59:03 +01:00
sneak deleted branch refactor/split-app-js 2026-02-26 10:59:03 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bot
Agent's turn to work
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
 notplanned
question
More information is needed
 wontfix
This won't be fixed
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/upaas#129
Delete Branch "refactor/split-app-js"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?