Compare commits
1
Commits
next
..
ef59c1512c
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ef59c1512c |
@@ -20,10 +20,6 @@ regress.
|
|||||||
|
|
||||||
# Completed Steps
|
# Completed Steps
|
||||||
|
|
||||||
- 2026-09-23: Fixed the flaky `t.TempDir` cleanup race in `internal/handlers`
|
|
||||||
(the one fixed in `internal/service/webhook` by #198):
|
|
||||||
`TestHandleWebhookProcessesValidWebhook` now waits with the webhook service's
|
|
||||||
`WaitForDeployments` instead of sleeping (#211).
|
|
||||||
- 2026-09-22: Vendored the canonical prettier/format toolchain from the
|
- 2026-09-22: Vendored the canonical prettier/format toolchain from the
|
||||||
`sneak/prompts` scaffold: added `.prettierrc` (tabWidth 4, proseWrap always),
|
`sneak/prompts` scaffold: added `.prettierrc` (tabWidth 4, proseWrap always),
|
||||||
pinned `package.json` + `yarn.lock` (prettier 3.8.1), taught
|
pinned `package.json` + `yarn.lock` (prettier 3.8.1), taught
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
"github.com/go-chi/chi/v5"
|
"github.com/go-chi/chi/v5"
|
||||||
"github.com/stretchr/testify/assert"
|
"github.com/stretchr/testify/assert"
|
||||||
@@ -42,7 +43,6 @@ type testContext struct {
|
|||||||
authSvc *auth.Service
|
authSvc *auth.Service
|
||||||
appSvc *app.Service
|
appSvc *app.Service
|
||||||
deploySvc *deploy.Service
|
deploySvc *deploy.Service
|
||||||
webhookSvc *webhook.Service
|
|
||||||
middleware *middleware.Middleware
|
middleware *middleware.Middleware
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -188,7 +188,6 @@ func setupTestHandlers(t *testing.T) *testContext {
|
|||||||
authSvc: authSvc,
|
authSvc: authSvc,
|
||||||
appSvc: appSvc,
|
appSvc: appSvc,
|
||||||
deploySvc: deploySvc,
|
deploySvc: deploySvc,
|
||||||
webhookSvc: webhookSvc,
|
|
||||||
middleware: mw,
|
middleware: mw,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1214,7 +1213,8 @@ func TestHandleWebhookProcessesValidWebhook(t *testing.T) {
|
|||||||
|
|
||||||
assert.Equal(t, http.StatusOK, recorder.Code)
|
assert.Equal(t, http.StatusOK, recorder.Code)
|
||||||
|
|
||||||
// Wait for the async deployment goroutine to finish so its writes
|
// Allow async deployment goroutine to complete before test cleanup.
|
||||||
// under the temp dir complete before test cleanup.
|
// The deployment will fail quickly (docker not connected) but we need
|
||||||
testCtx.webhookSvc.WaitForDeployments()
|
// to wait for it to finish to avoid temp directory cleanup race.
|
||||||
|
time.Sleep(100 * time.Millisecond)
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user