sneak/upaas
1
0
Fork 0
Code Issues 14 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(#124): remove unused imageID parameter from createAndStartContainer
Some checks failed
Check / check (pull_request) Failing after 6m8s
Details

Browse Source 
Remove the unused _ string (imageID) parameter from createAndStartContainer
and update its caller in deployContainerWithTimeout to stop passing it.
This commit is contained in:
user 2026-02-21 11:46:43 -08:00
parent 9eb0e0fcbf
commit 4d7fed6331
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/service/deploy/deploy.go
View File

@ -555,7 +555,7 @@ func (svc *Service) deployContainerWithTimeout(
svc.removeOldContainer(deployCtx, app, deployment) svc.removeOldContainer(deployCtx, app, deployment)
// Create and start the new container // Create and start the new container
_, err = svc.createAndStartContainer(deployCtx, app, deployment, imageID) _, err = svc.createAndStartContainer(deployCtx, app, deployment)
if err != nil { if err != nil {
if errors.Is(deployCtx.Err(), context.DeadlineExceeded) { if errors.Is(deployCtx.Err(), context.DeadlineExceeded) {
timeoutErr := fmt.Errorf("%w after %v", ErrDeployTimeout, deployTimeout) timeoutErr := fmt.Errorf("%w after %v", ErrDeployTimeout, deployTimeout)
@ -1018,7 +1018,6 @@ func (svc *Service) createAndStartContainer(
ctx context.Context, ctx context.Context,
app *models.App, app *models.App,
deployment *models.Deployment, deployment *models.Deployment,
_ string,
) (string, error) { ) (string, error) {
containerOpts, err := svc.buildContainerOptions(ctx, app, deployment.ID) containerOpts, err := svc.buildContainerOptions(ctx, app, deployment.ID)
if err != nil { if err != nil {