From 4d7fed63313d3324999d855fc097e3b3b0bdfbc1 Mon Sep 17 00:00:00 2001 From: user Date: Sat, 21 Feb 2026 11:46:43 -0800 Subject: [PATCH] fix(#124): remove unused imageID parameter from createAndStartContainer Remove the unused _ string (imageID) parameter from createAndStartContainer and update its caller in deployContainerWithTimeout to stop passing it. --- internal/service/deploy/deploy.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/service/deploy/deploy.go b/internal/service/deploy/deploy.go index 3093116..e98bed2 100644 --- a/internal/service/deploy/deploy.go +++ b/internal/service/deploy/deploy.go @@ -555,7 +555,7 @@ func (svc *Service) deployContainerWithTimeout( svc.removeOldContainer(deployCtx, app, deployment) // Create and start the new container - _, err = svc.createAndStartContainer(deployCtx, app, deployment, imageID) + _, err = svc.createAndStartContainer(deployCtx, app, deployment) if err != nil { if errors.Is(deployCtx.Err(), context.DeadlineExceeded) { timeoutErr := fmt.Errorf("%w after %v", ErrDeployTimeout, deployTimeout) @@ -1018,7 +1018,6 @@ func (svc *Service) createAndStartContainer( ctx context.Context, app *models.App, deployment *models.Deployment, - _ string, ) (string, error) { containerOpts, err := svc.buildContainerOptions(ctx, app, deployment.ID) if err != nil {