Merge pull request 'Set Secure flag on session cookie in production mode (closes #5)' (#10) from clawbot/upaas:fix/issue-5 into main

Reviewed-on: #10

internal/service/auth/auth.go

@@ -73,6 +73,7 @@ func New(_ fx.Lifecycle, params ServiceParams) (*Service, error) {
 		Path:     "/",
 		MaxAge:   sessionMaxAgeSeconds,
 		HttpOnly: true,
+		Secure:   !params.Config.Debug,
 		SameSite: http.SameSiteLaxMode,
 	}
 

internal/service/auth/auth_test.go

@@ -2,6 +2,8 @@ package auth_test
 
 import (
 	"context"
+	"net/http"
+	"net/http/httptest"
 	"path/filepath"
 	"testing"
 
@@ -68,6 +70,74 @@ func setupTestService(t *testing.T) (*auth.Service, func()) {
 	return svc, cleanup
 }
 
+func TestSessionCookieSecureFlag(testingT *testing.T) {
+	testingT.Parallel()
+
+	testingT.Run("secure flag is true when debug is false", func(t *testing.T) {
+		t.Parallel()
+
+		tmpDir := t.TempDir()
+
+		globals.SetAppname("upaas-test")
+		globals.SetVersion("test")
+
+		globalsInst, err := globals.New(fx.Lifecycle(nil))
+		require.NoError(t, err)
+
+		loggerInst, err := logger.New(
+			fx.Lifecycle(nil),
+			logger.Params{Globals: globalsInst},
+		)
+		require.NoError(t, err)
+
+		cfg := &config.Config{
+			Port:          8080,
+			DataDir:       tmpDir,
+			SessionSecret: "test-secret-key-at-least-32-chars",
+			Debug:         false,
+		}
+
+		dbInst, err := database.New(fx.Lifecycle(nil), database.Params{
+			Logger: loggerInst,
+			Config: cfg,
+		})
+		require.NoError(t, err)
+
+		svc, err := auth.New(fx.Lifecycle(nil), auth.ServiceParams{
+			Logger:   loggerInst,
+			Config:   cfg,
+			Database: dbInst,
+		})
+		require.NoError(t, err)
+
+		// Create user and session, check cookie has Secure flag
+		_, err = svc.CreateUser(context.Background(), "admin", "password123")
+		require.NoError(t, err)
+
+		user, err := svc.Authenticate(context.Background(), "admin", "password123")
+		require.NoError(t, err)
+
+		recorder := httptest.NewRecorder()
+		request := httptest.NewRequest(http.MethodGet, "/", nil)
+
+		err = svc.CreateSession(recorder, request, user)
+		require.NoError(t, err)
+
+		cookies := recorder.Result().Cookies()
+		require.NotEmpty(t, cookies)
+
+		var sessionCookie *http.Cookie
+		for _, c := range cookies {
+			if c.Name == "upaas_session" {
+				sessionCookie = c
+				break
+			}
+		}
+		require.NotNil(t, sessionCookie, "session cookie should exist")
+		assert.True(t, sessionCookie.Secure, "session cookie should have Secure flag in production mode")
+	})
+}
+
 func TestHashPassword(testingT *testing.T) {
 	testingT.Parallel()