Test only. The over-1 MiB cases of TestAnAnswerThatCannotBePassedOnIsAnswered502 left SWRP_TIMEOUT_MS at 2 s. On a loaded host rproxy used SWRP_DEFAULT_DISPOSITION before it had read the whole answer, and the test, which wants 502, failed. They now set SWRP_TIMEOUT_MS to 60000, as the file's other tests do where the time limit is not what they test.
The setting applies to every case of that test. The status-below-100 and held-101 cases are refused before any body is read, so the limit does not touch them.
Judgement call: TestAnAnswerThatCannotBePassedOnGetsNoReport sends the same over-1 MiB answer with the same 2 s limit and the same want of 502, so it gets the same setting.
Test only. The over-1 MiB cases of `TestAnAnswerThatCannotBePassedOnIsAnswered502` left `SWRP_TIMEOUT_MS` at 2 s. On a loaded host `rproxy` used `SWRP_DEFAULT_DISPOSITION` before it had read the whole answer, and the test, which wants `502`, failed. They now set `SWRP_TIMEOUT_MS` to `60000`, as the file's other tests do where the time limit is not what they test.
- The setting applies to every case of that test. The status-below-100 and held-101 cases are refused before any body is read, so the limit does not touch them.
- Judgement call: `TestAnAnswerThatCannotBePassedOnGetsNoReport` sends the same over-1 MiB answer with the same 2 s limit and the same want of `502`, so it gets the same setting.
Closes https://git.eeqj.de/sneak/smallwebwaf/issues/323
Model: opus-5-5
TestAnAnswerThatCannotBePassedOnIsAnswered502 and
TestAnAnswerThatCannotBePassedOnGetsNoReport left SWRP_TIMEOUT_MS at its
default of 2 s. On a loaded host rproxy had not read the whole answer of
1 MiB and one byte within that time, so it used SWRP_DEFAULT_DISPOSITION
and the tests, which want 502, failed. Both now set SWRP_TIMEOUT_MS to
60000, as the file's other tests do where the time limit is not what they
test.
Model: opus-5-5
PASS: both tests that send an over-1 MiB answer now set SWRP_TIMEOUT_MS to 60000, which meets the definition of done in #323.
Judgement call: TestAnAnswerOf1MiBGoesToTheVisitor reads a 1 MiB answer with the same 2 s limit and can fail the same way on a loaded host. That test is outside the linked issue, so it is not a finding here; it belongs on an issue of its own.
Model: opus-5-5
PASS: both tests that send an over-1 MiB answer now set `SWRP_TIMEOUT_MS` to `60000`, which meets the definition of done in https://git.eeqj.de/sneak/smallwebwaf/issues/323.
- Judgement call: `TestAnAnswerOf1MiBGoesToTheVisitor` reads a 1 MiB answer with the same 2 s limit and can fail the same way on a loaded host. That test is outside the linked issue, so it is not a finding here; it belongs on an issue of its own.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Test only. The over-1 MiB cases of
TestAnAnswerThatCannotBePassedOnIsAnswered502leftSWRP_TIMEOUT_MSat 2 s. On a loaded hostrproxyusedSWRP_DEFAULT_DISPOSITIONbefore it had read the whole answer, and the test, which wants502, failed. They now setSWRP_TIMEOUT_MSto60000, as the file's other tests do where the time limit is not what they test.TestAnAnswerThatCannotBePassedOnGetsNoReportsends the same over-1 MiB answer with the same 2 s limit and the same want of502, so it gets the same setting.Closes #323
Model: opus-5-5
PASS: both tests that send an over-1 MiB answer now set
SWRP_TIMEOUT_MSto60000, which meets the definition of done in #323.TestAnAnswerOf1MiBGoesToTheVisitorreads a 1 MiB answer with the same 2 s limit and can fail the same way on a loaded host. That test is outside the linked issue, so it is not a finding here; it belongs on an issue of its own.Model: opus-5-5