From the review of #328 (#328 (comment)): TestAnAnswerOf1MiBGoesToTheVisitor in internal/rproxy/rproxy_test.go reads an answer of 1 MiB from waf within the default SWRP_TIMEOUT_MS of 2 seconds. On a busy host that time can run out first, rproxy applies SWRP_DEFAULT_DISPOSITION as it should, and the test fails, as the over-1 MiB cases did in #323.
Definition of done, one PR into next, test only: the test sets SWRP_TIMEOUT_MS to 60000, as the file's other tests do where that limit is not what they test. No test, request or value is removed; no product limit changes. Follow AGENTS.md: checks only through make targets. make fmt, then flock -w 1800 /srv/code/tmp/.gate-smallwebwaf.lock make check; a flock timeout also exits 1, so read the output. Edit by hand. Title ending (closes #N) with this issue's number. Label the PR needs-review.
Model: opus-5-5
From the review of https://git.eeqj.de/sneak/smallwebwaf/pulls/328 (https://git.eeqj.de/sneak/smallwebwaf/pulls/328#issuecomment-177615): `TestAnAnswerOf1MiBGoesToTheVisitor` in `internal/rproxy/rproxy_test.go` reads an answer of 1 MiB from `waf` within the default `SWRP_TIMEOUT_MS` of 2 seconds. On a busy host that time can run out first, `rproxy` applies `SWRP_DEFAULT_DISPOSITION` as it should, and the test fails, as the over-1 MiB cases did in https://git.eeqj.de/sneak/smallwebwaf/issues/323.
**Definition of done**, one PR into `next`, test only: the test sets `SWRP_TIMEOUT_MS` to `60000`, as the file's other tests do where that limit is not what they test. No test, request or value is removed; no product limit changes. Follow `AGENTS.md`: checks only through `make` targets. `make fmt`, then `flock -w 1800 /srv/code/tmp/.gate-smallwebwaf.lock make check`; a `flock` timeout also exits 1, so read the output. Edit by hand. Title ending ` (closes #N)` with this issue's number. Label the PR `needs-review`.
Model: opus-5-5
clawbot
self-assigned this 2026-11-11 06:28:32 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
From the review of #328 (#328 (comment)):
TestAnAnswerOf1MiBGoesToTheVisitorininternal/rproxy/rproxy_test.goreads an answer of 1 MiB fromwafwithin the defaultSWRP_TIMEOUT_MSof 2 seconds. On a busy host that time can run out first,rproxyappliesSWRP_DEFAULT_DISPOSITIONas it should, and the test fails, as the over-1 MiB cases did in #323.Definition of done, one PR into
next, test only: the test setsSWRP_TIMEOUT_MSto60000, as the file's other tests do where that limit is not what they test. No test, request or value is removed; no product limit changes. FollowAGENTS.md: checks only throughmaketargets.make fmt, thenflock -w 1800 /srv/code/tmp/.gate-smallwebwaf.lock make check; aflocktimeout also exits 1, so read the output. Edit by hand. Title ending(closes #N)with this issue's number. Label the PRneeds-review.Model: opus-5-5
Built in #338:
TestAnAnswerOf1MiBGoesToTheVisitorsetsSWRP_TIMEOUT_MSto60000.Model: opus-5-5