Say ZFS counts a new file's blocks up to seconds after the write (closes #152) #153

Merged
clawbot merged 1 commits from issue-152-zfs-block-count into next 2026-11-03 05:00:52 +01:00
Collaborator

README.md and a comment in scan.go said ZFS counts a new file's blocks "only seconds after the write". That is false, because the count can land in under a second. Both now say "up to seconds after the write", which agrees with the comment on diskSizeOf in scan_test.go. TODO.md records the step.

The README diff shows three lines because make fmt rewrapped the paragraph. Only one sentence changed.

Judgement call: the later README sentence "A file scanned within those seconds" stays as it is, because it is still true and the issue limits the change.

Closes #152

Model: opus-5-5

`README.md` and a comment in `scan.go` said ZFS counts a new file's blocks "only seconds after the write". That is false, because the count can land in under a second. Both now say "up to seconds after the write", which agrees with the comment on `diskSizeOf` in `scan_test.go`. `TODO.md` records the step. The README diff shows three lines because `make fmt` rewrapped the paragraph. Only one sentence changed. Judgement call: the later README sentence "A file scanned within those seconds" stays as it is, because it is still true and the issue limits the change. Closes https://git.eeqj.de/sneak/sfdupes/issues/152 Model: opus-5-5
clawbot added the needs-review label 2026-11-03 04:31:47 +01:00
clawbot self-assigned this 2026-11-03 04:31:47 +01:00
clawbot added 1 commit 2026-11-03 04:31:47 +01:00
`README.md` and a comment in `scan.go` said "only seconds after the write". That is false, because the count can land in under a second. Both now agree with the comment on `diskSizeOf` in `scan_test.go`.

Model: opus-5-5
Author
Collaborator

PASS: the sentences changed in README.md, scan.go and TODO.md by #153 are true and read clearly, and the PR changes nothing else.

Model: opus-5-5

PASS: the sentences changed in `README.md`, `scan.go` and `TODO.md` by https://git.eeqj.de/sneak/sfdupes/pulls/153 are true and read clearly, and the PR changes nothing else. Model: opus-5-5
clawbot merged commit f52bbe5d95 into next 2026-11-03 05:00:52 +01:00
Sign in to join this conversation.