The disk_size bullet under "What a scan does to the database" in README.md, and the comment at scan.go line 557, say that ZFS "counts a new file's blocks only seconds after the write". That is false: the count can land in under a second. The comment on diskSizeOf in scan_test.go already says it correctly, as "up to seconds later". The review of #151 noted this.
What to change. Those two sentences, so that they say the same as the diskSizeOf comment, plus the TODO.md entry. Nothing else.
Definition of done. One short correct sentence in each place, make fmt applied, make check passing on a branch rebased onto current next, and one independent review that reads only those sentences.
Model: opus-5-5
The `disk_size` bullet under "What a scan does to the database" in `README.md`, and the comment at `scan.go` line 557, say that ZFS "counts a new file's blocks only seconds after the write". That is false: the count can land in under a second. The comment on `diskSizeOf` in `scan_test.go` already says it correctly, as "up to seconds later". The review of https://git.eeqj.de/sneak/sfdupes/pulls/151 noted this.
**What to change.** Those two sentences, so that they say the same as the `diskSizeOf` comment, plus the `TODO.md` entry. Nothing else.
**Definition of done.** One short correct sentence in each place, `make fmt` applied, `make check` passing on a branch rebased onto current `next`, and one independent review that reads only those sentences.
Model: opus-5-5
clawbot
self-assigned this 2026-11-03 04:29:20 +01:00
Built in #153: the disk_size bullet in README.md and the comment in scan.go now say "up to seconds after the write".
Model: opus-5-5
Built in https://git.eeqj.de/sneak/sfdupes/pulls/153: the `disk_size` bullet in `README.md` and the comment in `scan.go` now say "up to seconds after the write".
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The
disk_sizebullet under "What a scan does to the database" inREADME.md, and the comment atscan.goline 557, say that ZFS "counts a new file's blocks only seconds after the write". That is false: the count can land in under a second. The comment ondiskSizeOfinscan_test.goalready says it correctly, as "up to seconds later". The review of #151 noted this.What to change. Those two sentences, so that they say the same as the
diskSizeOfcomment, plus theTODO.mdentry. Nothing else.Definition of done. One short correct sentence in each place,
make fmtapplied,make checkpassing on a branch rebased onto currentnext, and one independent review that reads only those sentences.Model: opus-5-5
Built in #153: the
disk_sizebullet inREADME.mdand the comment inscan.gonow say "up to seconds after the write".Model: opus-5-5