Adds .editorconfig, copied verbatim from sneak/dnswatcher (root = true; space/4/lf/utf-8/trim/final-newline, with [Makefile] overriding to tab). secret had none. Resolves#27.
make check is green on the host (0 issues, all packages pass). Note: docker build . fails only on a pre-existing, environmental memguardmlock / RLIMIT_MEMLOCK issue in the 10MB-secret test — it reproduces identically on pristine origin/main with this file removed, and secret's real CI sets the memlock ulimit for it. A static config file cannot affect Go tests, so this change is clean; the container ulimit is a separate pre-existing concern.
Left open for review (not merged).
Adds `.editorconfig`, copied verbatim from `sneak/dnswatcher` (`root = true`; space/4/lf/utf-8/trim/final-newline, with `[Makefile]` overriding to tab). secret had none. Resolves #27.
`make check` is green on the host (`0 issues`, all packages pass). Note: `docker build .` fails only on a pre-existing, environmental `memguard` `mlock` / `RLIMIT_MEMLOCK` issue in the 10MB-secret test — it reproduces identically on pristine `origin/main` with this file removed, and secret's real CI sets the memlock ulimit for it. A static config file cannot affect Go tests, so this change is clean; the container ulimit is a separate pre-existing concern.
Left open for review (not merged).
Independent adversarial review (reviewer separate from the author):
Review of PR #28 (sneak/secret, issue-27-editorconfig, 8ccd2bf)
1. Scope — PASS. Diff adds exactly one file, .editorconfig (12 lines, +12). Diffstat shows 1 file changed, 12 insertions(+). Nothing else touched: no other files, no artifacts, no secrets. Single commit on the branch.
2. Content — PASS. Byte-identical to sneak/dnswatcher's .editorconfig. Line-by-line match (root=true; [*] block: space / size 4 / lf / utf-8 / trim_trailing_whitespace / insert_final_newline; [Makefile] to tab). cat -A confirms clean lf endings, final newline present, no trailing whitespace, no CRLF. Definitive: the git blob index in the diff (2fe0ce0) equals dnswatcher's blob SHA (2fe0ce08508c...), so the files are provably identical at the byte level.
3. No side effects — PASS..editorconfig is advisory metadata consumed only by editors/IDEs; it is not read by go build, go test, golangci-lint, or the Makefile, so it cannot affect make check/tests/lint. No golangci sandbox-path quirks encountered (review was read-only via git, no temp worktree). Fixer's report of make check green (0 issues) is consistent with a no-op-to-tooling change.
4. Hygiene — PASS. Commit title: Add .editorconfig for consistent editor defaults (closes #27) — ends with (closes #27). Full commit body is just that one line; no Claude/Anthropic/AI/Co-Authored-By/claude.ai references in the message or diff.
VERDICT: PASS
Independent adversarial review (reviewer separate from the author):
## Review of PR #28 (sneak/secret, `issue-27-editorconfig`, `8ccd2bf`)
**1. Scope — PASS.** Diff adds exactly one file, `.editorconfig` (12 lines, +12). Diffstat shows `1 file changed, 12 insertions(+)`. Nothing else touched: no other files, no artifacts, no secrets. Single commit on the branch.
**2. Content — PASS.** Byte-identical to `sneak/dnswatcher`'s `.editorconfig`. Line-by-line match (root=true; `[*]` block: space / size 4 / lf / utf-8 / trim_trailing_whitespace / insert_final_newline; `[Makefile]` to tab). `cat -A` confirms clean `lf` endings, final newline present, no trailing whitespace, no CRLF. Definitive: the git blob index in the diff (`2fe0ce0`) equals dnswatcher's blob SHA (`2fe0ce08508c...`), so the files are provably identical at the byte level.
**3. No side effects — PASS.** `.editorconfig` is advisory metadata consumed only by editors/IDEs; it is not read by `go build`, `go test`, `golangci-lint`, or the Makefile, so it cannot affect `make check`/tests/lint. No golangci sandbox-path quirks encountered (review was read-only via git, no temp worktree). Fixer's report of `make check` green (0 issues) is consistent with a no-op-to-tooling change.
**4. Hygiene — PASS.** Commit title: `Add .editorconfig for consistent editor defaults (closes #27)` — ends with ` (closes #27)`. Full commit body is just that one line; no Claude/Anthropic/AI/Co-Authored-By/claude.ai references in the message or diff.
VERDICT: PASS
sneak
merged commit 6e5e0db999 into main2026-08-07 17:46:27 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Adds
.editorconfig, copied verbatim fromsneak/dnswatcher(root = true; space/4/lf/utf-8/trim/final-newline, with[Makefile]overriding to tab). secret had none. Resolves #27.make checkis green on the host (0 issues, all packages pass). Note:docker build .fails only on a pre-existing, environmentalmemguardmlock/RLIMIT_MEMLOCKissue in the 10MB-secret test — it reproduces identically on pristineorigin/mainwith this file removed, and secret's real CI sets the memlock ulimit for it. A static config file cannot affect Go tests, so this change is clean; the container ulimit is a separate pre-existing concern.Left open for review (not merged).
Independent adversarial review (reviewer separate from the author):
Review of PR #28 (sneak/secret,
issue-27-editorconfig,8ccd2bf)1. Scope — PASS. Diff adds exactly one file,
.editorconfig(12 lines, +12). Diffstat shows1 file changed, 12 insertions(+). Nothing else touched: no other files, no artifacts, no secrets. Single commit on the branch.2. Content — PASS. Byte-identical to
sneak/dnswatcher's.editorconfig. Line-by-line match (root=true;[*]block: space / size 4 / lf / utf-8 / trim_trailing_whitespace / insert_final_newline;[Makefile]to tab).cat -Aconfirms cleanlfendings, final newline present, no trailing whitespace, no CRLF. Definitive: the git blob index in the diff (2fe0ce0) equals dnswatcher's blob SHA (2fe0ce08508c...), so the files are provably identical at the byte level.3. No side effects — PASS.
.editorconfigis advisory metadata consumed only by editors/IDEs; it is not read bygo build,go test,golangci-lint, or the Makefile, so it cannot affectmake check/tests/lint. No golangci sandbox-path quirks encountered (review was read-only via git, no temp worktree). Fixer's report ofmake checkgreen (0 issues) is consistent with a no-op-to-tooling change.4. Hygiene — PASS. Commit title:
Add .editorconfig for consistent editor defaults (closes #27)— ends with(closes #27). Full commit body is just that one line; no Claude/Anthropic/AI/Co-Authored-By/claude.ai references in the message or diff.VERDICT: PASS