sneak/secret
1
0
Fork 0
Code Issues 22 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add .editorconfig (closes #27) #28

Merged
sneak merged 1 commits from issue-27-editorconfig into main 2026-08-07 17:46:27 +02:00
Conversation 1 Commits 1 Files Changed 1 +12
clawbot commented 2026-07-26 20:55:51 +02:00
Collaborator
Copy Link

Adds .editorconfig, copied verbatim from sneak/dnswatcher (root = true; space/4/lf/utf-8/trim/final-newline, with [Makefile] overriding to tab). secret had none. Resolves #27.

make check is green on the host (0 issues, all packages pass). Note: docker build . fails only on a pre-existing, environmental memguard mlock / RLIMIT_MEMLOCK issue in the 10MB-secret test — it reproduces identically on pristine origin/main with this file removed, and secret's real CI sets the memlock ulimit for it. A static config file cannot affect Go tests, so this change is clean; the container ulimit is a separate pre-existing concern.

Left open for review (not merged).

Adds `.editorconfig`, copied verbatim from `sneak/dnswatcher` (`root = true`; space/4/lf/utf-8/trim/final-newline, with `[Makefile]` overriding to tab). secret had none. Resolves #27. `make check` is green on the host (`0 issues`, all packages pass). Note: `docker build .` fails only on a pre-existing, environmental `memguard` `mlock` / `RLIMIT_MEMLOCK` issue in the 10MB-secret test — it reproduces identically on pristine `origin/main` with this file removed, and secret's real CI sets the memlock ulimit for it. A static config file cannot affect Go tests, so this change is clean; the container ulimit is a separate pre-existing concern. Left open for review (not merged).
clawbot added 1 commit 2026-07-26 20:55:51 +02:00
Add .editorconfig for consistent editor defaults (closes #27)
All checks were successful
check / check (push) Successful in 47s
Details
8ccd2bfd45
clawbot commented 2026-08-04 01:59:50 +02:00
Author
Collaborator
Copy Link

Independent adversarial review (reviewer separate from the author):

Review of PR #28 (sneak/secret, issue-27-editorconfig, 8ccd2bf)

1. Scope — PASS. Diff adds exactly one file, .editorconfig (12 lines, +12). Diffstat shows 1 file changed, 12 insertions(+). Nothing else touched: no other files, no artifacts, no secrets. Single commit on the branch.

2. Content — PASS. Byte-identical to sneak/dnswatcher's .editorconfig. Line-by-line match (root=true; [*] block: space / size 4 / lf / utf-8 / trim_trailing_whitespace / insert_final_newline; [Makefile] to tab). cat -A confirms clean lf endings, final newline present, no trailing whitespace, no CRLF. Definitive: the git blob index in the diff (2fe0ce0) equals dnswatcher's blob SHA (2fe0ce08508c...), so the files are provably identical at the byte level.

3. No side effects — PASS. .editorconfig is advisory metadata consumed only by editors/IDEs; it is not read by go build, go test, golangci-lint, or the Makefile, so it cannot affect make check/tests/lint. No golangci sandbox-path quirks encountered (review was read-only via git, no temp worktree). Fixer's report of make check green (0 issues) is consistent with a no-op-to-tooling change.

4. Hygiene — PASS. Commit title: Add .editorconfig for consistent editor defaults (closes #27) — ends with (closes #27). Full commit body is just that one line; no Claude/Anthropic/AI/Co-Authored-By/claude.ai references in the message or diff.

VERDICT: PASS

Independent adversarial review (reviewer separate from the author): ## Review of PR #28 (sneak/secret, `issue-27-editorconfig`, `8ccd2bf`) **1. Scope — PASS.** Diff adds exactly one file, `.editorconfig` (12 lines, +12). Diffstat shows `1 file changed, 12 insertions(+)`. Nothing else touched: no other files, no artifacts, no secrets. Single commit on the branch. **2. Content — PASS.** Byte-identical to `sneak/dnswatcher`'s `.editorconfig`. Line-by-line match (root=true; `[*]` block: space / size 4 / lf / utf-8 / trim_trailing_whitespace / insert_final_newline; `[Makefile]` to tab). `cat -A` confirms clean `lf` endings, final newline present, no trailing whitespace, no CRLF. Definitive: the git blob index in the diff (`2fe0ce0`) equals dnswatcher's blob SHA (`2fe0ce08508c...`), so the files are provably identical at the byte level. **3. No side effects — PASS.** `.editorconfig` is advisory metadata consumed only by editors/IDEs; it is not read by `go build`, `go test`, `golangci-lint`, or the Makefile, so it cannot affect `make check`/tests/lint. No golangci sandbox-path quirks encountered (review was read-only via git, no temp worktree). Fixer's report of `make check` green (0 issues) is consistent with a no-op-to-tooling change. **4. Hygiene — PASS.** Commit title: `Add .editorconfig for consistent editor defaults (closes #27)` — ends with ` (closes #27)`. Full commit body is just that one line; no Claude/Anthropic/AI/Co-Authored-By/claude.ai references in the message or diff. VERDICT: PASS
sneak merged commit 6e5e0db999 into main 2026-08-07 17:46:27 +02:00
sneak deleted branch issue-27-editorconfig 2026-08-07 17:46:27 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/secret#28
Delete Branch "issue-27-editorconfig"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?