Use a made-up host name in the secret-name test fixture (closes #200) #201

Open
clawbot wants to merge 1 commits from issue-200-fixture-hostname into next
pull from: issue-200-fixture-hostname
Collaborator

The example secret name in internal/vault/secrets_name_test.go contained the name of one of our servers. It now uses the made-up host1; the rest of the name, including the uppercase key ID the case tests, is unchanged. Nothing else on next names a host of ours.

closes #200

Model: opus-5-5

The example secret name in `internal/vault/secrets_name_test.go` contained the name of one of our servers. It now uses the made-up `host1`; the rest of the name, including the uppercase key ID the case tests, is unchanged. Nothing else on `next` names a host of ours. closes https://git.eeqj.de/sneak/secret/issues/200 Model: opus-5-5
clawbot added the needs-review label 2026-11-16 06:57:07 +01:00
clawbot self-assigned this 2026-11-16 06:57:07 +01:00
Author
Collaborator

Verdict: FAIL
Head: 3aeb8f1cb6

  1. TODO.md: the PR adds a dated entry under Completed Steps, which is a work log. On 11 November sneak ruled that TODO.md is not a history document and that finished work is deleted from it (the issue to remove work logs from TODO.md: #198). The fixture issue (#200) asks for no TODO.md change. The entry also edits the section that the open work-log removal PR (#199) deletes, so whichever of the two merges second conflicts. Acceptable: drop the TODO.md change, so the PR changes only internal/vault/secrets_name_test.go. The Workflow line in TODO.md that says to log finished work is out of date, and that PR removes it.

Model: opus-5-5

Verdict: FAIL Head: 3aeb8f1cb62115d8542c7aba5f18433b59668c33 1. `TODO.md`: the PR adds a dated entry under `Completed Steps`, which is a work log. On 11 November sneak ruled that `TODO.md` is not a history document and that finished work is deleted from it (the issue to remove work logs from `TODO.md`: https://git.eeqj.de/sneak/secret/issues/198). The fixture issue (https://git.eeqj.de/sneak/secret/issues/200) asks for no `TODO.md` change. The entry also edits the section that the open work-log removal PR (https://git.eeqj.de/sneak/secret/pulls/199) deletes, so whichever of the two merges second conflicts. Acceptable: drop the `TODO.md` change, so the PR changes only `internal/vault/secrets_name_test.go`. The Workflow line in `TODO.md` that says to log finished work is out of date, and that PR removes it. Model: opus-5-5
Author
Collaborator

For the reworker: do what the review says. Drop the TODO.md change so the PR changes only internal/vault/secrets_name_test.go, push, and stop.

Model: opus-5-5

For the reworker: do what the review says. Drop the `TODO.md` change so the PR changes only `internal/vault/secrets_name_test.go`, push, and stop. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-11-16 07:24:27 +01:00
clawbot added 1 commit 2026-11-16 07:26:02 +01:00
The example secret name in the uppercase-name test contained the name of
one of our servers. It now uses host1; the rest of the name, including the
uppercase key ID, is unchanged.

Model: opus-5-5
clawbot force-pushed issue-200-fixture-hostname from 3aeb8f1cb6 to dfe76306ea 2026-11-16 07:26:02 +01:00 Compare
Author
Collaborator
  1. Done: the commit no longer changes TODO.md; new head dfe76306ea7025a4211b3417aa4b4af80e0d47b4, on current next.

Model: opus-5-5

1. Done: the commit no longer changes `TODO.md`; new head `dfe76306ea7025a4211b3417aa4b4af80e0d47b4`, on current `next`. Model: opus-5-5
clawbot added needs-review and removed needs-rework labels 2026-11-16 07:28:03 +01:00
Author
Collaborator

Verdict: PASS
Head: dfe76306ea

The example secret name in internal/vault/secrets_name_test.go no longer names a host of ours, nothing else in the tree on next does, and the change is limited to that one line.

  • Disclosure: leaving out a TODO.md entry follows sneak's 11 November ruling that TODO.md is not a history document (#198), which cuts against the TODO.md Workflow step "log it at the top of Completed Steps".

Model: opus-5-5

Verdict: PASS Head: dfe76306ea7025a4211b3417aa4b4af80e0d47b4 The example secret name in `internal/vault/secrets_name_test.go` no longer names a host of ours, nothing else in the tree on `next` does, and the change is limited to that one line. - Disclosure: leaving out a `TODO.md` entry follows sneak's 11 November ruling that `TODO.md` is not a history document (https://git.eeqj.de/sneak/secret/issues/198), which cuts against the `TODO.md` Workflow step "log it at the top of Completed Steps". Model: opus-5-5
Some checks are pending
check / check (push) In progress
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin issue-200-fixture-hostname:issue-200-fixture-hostname
git checkout issue-200-fixture-hostname
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/secret#201