A test fixture names one of our servers #200

Open
opened 2026-11-16 06:40:55 +01:00 by clawbot · 1 comment
Collaborator

sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts.

This repo breaks it in one test on next: internal/vault/secrets_name_test.go, line 22. The example secret name, taken from real use, contains the name of one of our servers.

main has two more places, both already gone from next: Makefile, line 2, sets DOCKER_HOST to an SSH target on one of our machines, and internal/secret/secret_test.go, line 348, uses the same example name. They leave main when sneak merges next; nothing is to be done for them here.

Work

  • In the example secret name on line 22, replace the server's name with a made-up one such as host1. Keep the rest of the name: the case tests a name with an uppercase key ID.
  • The PR targets next.

Definition of done

  • Line 22 names no host of ours, and nothing else in the tree on next does.
  • make check passes.

Model: fable-5-2

sneak's standing rule (16 November): a public repo never names our own infrastructure. No hostname, host address, SSH target or internal URL of ours appears in code, defaults, docs, issues, PRs or commit messages. It is a security exposure, and general-purpose software has nothing to do with our hosts. This repo breaks it in one test on `next`: `internal/vault/secrets_name_test.go`, line 22. The example secret name, taken from real use, contains the name of one of our servers. `main` has two more places, both already gone from `next`: `Makefile`, line 2, sets `DOCKER_HOST` to an SSH target on one of our machines, and `internal/secret/secret_test.go`, line 348, uses the same example name. They leave `main` when sneak merges `next`; nothing is to be done for them here. ## Work - In the example secret name on line 22, replace the server's name with a made-up one such as `host1`. Keep the rest of the name: the case tests a name with an uppercase key ID. - The PR targets `next`. ## Definition of done - Line 22 names no host of ours, and nothing else in the tree on `next` does. - `make check` passes. Model: fable-5-2
Author
Collaborator

Built in #201 (branch issue-200-fixture-hostname): the example secret name now uses host1 in place of the server's name. Nothing else on next names a host of ours.

Model: opus-5-5

Built in https://git.eeqj.de/sneak/secret/pulls/201 (branch `issue-200-fixture-hostname`): the example secret name now uses `host1` in place of the server's name. Nothing else on `next` names a host of ours. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/secret#200