Format and check markdown with prettier in make fmt and fmt-check (closes #110) #117

Merged
clawbot merged 1 commits from issue-110-format-markdown into next 2026-10-05 02:07:55 +02:00
Collaborator

make fmt and make fmt-check now cover markdown as well as Go, as the model scripts in the prompts repo and REPO_POLICIES.md require (#110).

  • script/fmt and script/fmt-check: Go formatting as before, then prettier over every markdown file with 4-space tabs and proseWrap: always, run through yarn the way the model scripts do.
  • Prettier is pinned by hash in package.json and yarn.lock, both copied from the model. script/bootstrap now runs its node, yarn and JS dependency steps.
  • Dockerfile lint stage: node and yarn are copied in from a node:22.17.0-bookworm-slim image pinned by digest, and the stage runs script/bootstrap instead of go mod download. Its existing make fmt-check therefore fails script/cibuild on an unformatted markdown file.
  • Every markdown file is formatted once: line wrapping, blank lines and nested list indentation only. README.md Entrypoints and TODO.md are updated.

Not visible in the diff:

  • The lint stage is the Debian-based golangci-lint image, which has no node. The model's node:22-alpine image cannot supply it there, since its binaries are built for a different C library. So the node image is a Debian one, at the version script/bootstrap pins.
  • script/lint, script/lint-darwin and Dockerfile.lint are unchanged.

Disclosures:

  • Deviation: git diff --word-diff shows 19 changes, all in CLAUDE.md, where list markers * become -. Prettier has no setting that keeps *. No words change.
  • Judgement call: no .prettierrc. The settings are passed on the command line, as the model scripts do.

Model: opus-5-5

`make fmt` and `make fmt-check` now cover markdown as well as Go, as the model scripts in the `prompts` repo and `REPO_POLICIES.md` require (https://git.eeqj.de/sneak/secret/issues/110). - `script/fmt` and `script/fmt-check`: Go formatting as before, then prettier over every markdown file with 4-space tabs and `proseWrap: always`, run through yarn the way the model scripts do. - Prettier is pinned by hash in `package.json` and `yarn.lock`, both copied from the model. `script/bootstrap` now runs its node, yarn and JS dependency steps. - `Dockerfile` lint stage: node and yarn are copied in from a `node:22.17.0-bookworm-slim` image pinned by digest, and the stage runs `script/bootstrap` instead of `go mod download`. Its existing `make fmt-check` therefore fails `script/cibuild` on an unformatted markdown file. - Every markdown file is formatted once: line wrapping, blank lines and nested list indentation only. `README.md` Entrypoints and `TODO.md` are updated. Not visible in the diff: - The lint stage is the Debian-based golangci-lint image, which has no node. The model's `node:22-alpine` image cannot supply it there, since its binaries are built for a different C library. So the node image is a Debian one, at the version `script/bootstrap` pins. - `script/lint`, `script/lint-darwin` and `Dockerfile.lint` are unchanged. Disclosures: - Deviation: `git diff --word-diff` shows 19 changes, all in `CLAUDE.md`, where list markers `*` become `-`. Prettier has no setting that keeps `*`. No words change. - Judgement call: no `.prettierrc`. The settings are passed on the command line, as the model scripts do. Model: opus-5-5
clawbot added the needs-review label 2026-10-05 01:51:43 +02:00
clawbot self-assigned this 2026-10-05 01:51:43 +02:00
clawbot added 1 commit 2026-10-05 01:51:43 +02:00
script/fmt and script/fmt-check follow the model scripts in the prompts
repo: Go as before, plus prettier over every markdown file with 4-space
tabs and proseWrap always. Prettier is pinned by hash in package.json and
yarn.lock; script/bootstrap now installs node, yarn and prettier. The
Dockerfile lint stage copies node and yarn from a node image pinned by
hash and runs script/bootstrap, so its make fmt-check fails the build on
unformatted markdown. Every markdown file is formatted once; wording is
unchanged (CLAUDE.md's "*" list markers become "-").

Model: opus-5-5
Author
Collaborator

PASS: make fmt and make fmt-check now format and check every markdown file with pinned prettier as the model scripts do, the Dockerfile lint stage fails on unformatted markdown, and the one-time reformat changes layout only.

Model: opus-5-5

PASS: `make fmt` and `make fmt-check` now format and check every markdown file with pinned prettier as the model scripts do, the `Dockerfile` lint stage fails on unformatted markdown, and the one-time reformat changes layout only. Model: opus-5-5
clawbot merged commit 047f347955 into next 2026-10-05 02:07:55 +02:00
clawbot deleted branch issue-110-format-markdown 2026-10-05 02:07:55 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/secret#117