sneak/secret
1
0
Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

make fmt and make fmt-check ignore markdown #110

New Issue
Closed
opened 2026-10-04 20:59:29 +02:00 by clawbot · 1 comment
clawbot commented 2026-10-04 20:59:29 +02:00
Collaborator
Copy Link
Copy Source

Raised in several reviews today (for example #107): script/fmt runs only go fmt and script/fmt-check only gofmt -l, so markdown is never formatted or checked. REPO_POLICIES.md and the canonical model scripts (https://git.eeqj.de/sneak/prompts/raw/branch/main/script/fmt and script/fmt-check) also run prettier over **/*.md with 4-space tabs and proseWrap: always, and TODO.md and README.md here are wrapped by hand, inconsistently.

Definition of done

  • script/fmt and script/fmt-check follow the canonical model scripts: Go as now, plus prettier over every markdown file with the repo settings, prettier pinned by hash (package.json and yarn.lock, installed by script/bootstrap as the model does) or run in a pinned Docker image, whichever the model scripts do.
  • The Dockerfile lint stage and script/cibuild run the markdown check too, so an unformatted markdown file fails the build.
  • Every markdown file is formatted once in the same commit, wording unchanged.
  • README.md Entrypoints describes the new behaviour; TODO.md updated.

Sequencing

Last but one, before #43: it rewraps TODO.md, which every other unit edits.

Model: opus-5-5

Raised in several reviews today (for example https://git.eeqj.de/sneak/secret/pulls/107): `script/fmt` runs only `go fmt` and `script/fmt-check` only `gofmt -l`, so markdown is never formatted or checked. `REPO_POLICIES.md` and the canonical model scripts (https://git.eeqj.de/sneak/prompts/raw/branch/main/script/fmt and `script/fmt-check`) also run prettier over `**/*.md` with 4-space tabs and `proseWrap: always`, and `TODO.md` and `README.md` here are wrapped by hand, inconsistently. ## Definition of done - `script/fmt` and `script/fmt-check` follow the canonical model scripts: Go as now, plus prettier over every markdown file with the repo settings, prettier pinned by hash (`package.json` and `yarn.lock`, installed by `script/bootstrap` as the model does) or run in a pinned Docker image, whichever the model scripts do. - The `Dockerfile` lint stage and `script/cibuild` run the markdown check too, so an unformatted markdown file fails the build. - Every markdown file is formatted once in the same commit, wording unchanged. - `README.md` Entrypoints describes the new behaviour; `TODO.md` updated. ## Sequencing Last but one, before https://git.eeqj.de/sneak/secret/issues/43: it rewraps `TODO.md`, which every other unit edits. Model: opus-5-5
clawbot commented 2026-10-05 01:51:48 +02:00
Author
Collaborator
Copy Link
Copy Source

Implemented in #117: make fmt and make fmt-check now format and check every markdown file with prettier as well as the Go code, and the Dockerfile lint stage fails the build on unformatted markdown. Details are in the PR.

Model: opus-5-5

Implemented in https://git.eeqj.de/sneak/secret/pulls/117: `make fmt` and `make fmt-check` now format and check every markdown file with prettier as well as the Go code, and the `Dockerfile` lint stage fails the build on unformatted markdown. Details are in the PR. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
needs-checks
needs-rebase
needs-review
needs-rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/secret#110