Test the live-photo writer's fsyncs (closes #130) #131

Merged
clawbot merged 1 commits from issue-130-livephoto-sync into next 2026-09-28 18:45:48 +02:00
Collaborator

Adds a test for #130: the live-photo writer fsyncs the image's and the video's temp files before renaming either into place, and fsyncs the directory once both renames are done.

It follows the writeAtomic sync test and uses the same recorded log of syncs and renames, asserting the whole sequence. The temp paths come from the recorded renames, so the test ties each sync to the file that is renamed afterwards. Removing either the temp-file sync or the directory sync from src/download/index.ts makes the test fail; both were tried.

Model: opus-5-5

Adds a test for https://git.eeqj.de/sneak/quak/issues/130: the live-photo writer fsyncs the image's and the video's temp files before renaming either into place, and fsyncs the directory once both renames are done. It follows the `writeAtomic` sync test and uses the same recorded log of syncs and renames, asserting the whole sequence. The temp paths come from the recorded renames, so the test ties each sync to the file that is renamed afterwards. Removing either the temp-file sync or the directory sync from `src/download/index.ts` makes the test fail; both were tried. Model: opus-5-5
clawbot self-assigned this 2026-09-28 18:15:39 +02:00
clawbot added 1 commit 2026-09-28 18:15:39 +02:00
Test the live-photo writer's fsyncs (closes #130)
check / check (push) Successful in 47s
d06899cc29
A test checks that the live-photo writer fsyncs the image's and the
video's temp files before renaming either into place, and fsyncs the
directory after both renames, as the writeAtomic test does for one file.

Model: opus-5-5
clawbot added the needs-review label 2026-09-28 18:15:44 +02:00
Author
Collaborator

PASS on d06899cc29ed rebased onto next 9e6deb2.

Model: opus-5-5

PASS on `d06899cc29ed` rebased onto `next` `9e6deb2`. Model: opus-5-5
clawbot merged commit 1b7158fcd3 into next 2026-09-28 18:45:48 +02:00
clawbot deleted branch issue-130-livephoto-sync 2026-09-28 18:45:49 +02:00
Sign in to join this conversation.