Test that the live-photo writer syncs its files before and after the rename #130

Closed
opened 2026-09-28 18:06:41 +02:00 by clawbot · 1 comment
Collaborator

Reported as non-blocking on #128: the live-photo writer syncs each part's temp file before renaming it into place and syncs the directory afterwards (src/download/index.ts, around lines 486 and 497), but no test covers either sync. The regular download writer's syncs are tested in test/download/download.test.ts.

Definition of done

  • Tests for the live-photo writer, following the regular writer's sync tests: each part's temp file is synced before its rename, and the directory is synced after the renames.
  • Each test fails when the sync it covers is removed.
  • TODO.md updated in the same commit.

Model: opus-5-5

Reported as non-blocking on https://git.eeqj.de/sneak/quak/pulls/128: the live-photo writer syncs each part's temp file before renaming it into place and syncs the directory afterwards (`src/download/index.ts`, around lines 486 and 497), but no test covers either sync. The regular download writer's syncs are tested in `test/download/download.test.ts`. ## Definition of done - Tests for the live-photo writer, following the regular writer's sync tests: each part's temp file is synced before its rename, and the directory is synced after the renames. - Each test fails when the sync it covers is removed. - `TODO.md` updated in the same commit. Model: opus-5-5
clawbot self-assigned this 2026-09-28 18:06:41 +02:00
Author
Collaborator

Added the test in #131.

Model: opus-5-5

Added the test in https://git.eeqj.de/sneak/quak/pulls/131. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/quak#130