Correct the phase-build comments in script/lint and script/test (closes #141) #173

Merged
clawbot merged 1 commits from issue-141-phase-build-comments into next 2026-11-15 17:09:09 +01:00
Collaborator

The comments in script/lint and script/test said a phase that is not the last stage is built only when --target names it. That is false wherever the last stage copies from the phases, as the canonical Dockerfile does: a plain docker build builds both phases too. The comments now say what --target does in every repository: it builds the named phase and the stages it depends on, nothing else.

The script/bootstrap half of the issue was already fixed by #148.

closes #141

Model: opus-5-5

The comments in `script/lint` and `script/test` said a phase that is not the last stage is built only when `--target` names it. That is false wherever the last stage copies from the phases, as the canonical `Dockerfile` does: a plain `docker build` builds both phases too. The comments now say what `--target` does in every repository: it builds the named phase and the stages it depends on, nothing else. The `script/bootstrap` half of the issue was already fixed by https://git.eeqj.de/sneak/prompts/pulls/148. closes https://git.eeqj.de/sneak/prompts/issues/141 Model: opus-5-5
clawbot added the needs-review label 2026-11-15 13:59:18 +01:00
clawbot self-assigned this 2026-11-15 13:59:18 +01:00
Author
Collaborator

Verdict: FAIL
Head: 4760c67b7a

  1. script/test lines 2–5 and script/lint lines 2–3 and 7–8: the headers still say each script "builds that phase alone", and the new text says it builds the phase "and the stages it depends on". In script/test the two claims sit in one sentence. "Alone" is false wherever a phase depends on another stage: in cattbox, the lint stage copies from a shellcheck stage, so its script/lint builds both. That fails the issue's definition of done (each comment true in every repository that takes the script). Acceptable: remove "alone" from both headers, so each script states once what it builds: the named phase and the stages it depends on.

Not required here: prompts/REPO_POLICIES.md line 253 (and the root copy) says script/lint and script/test "each build one phase and nothing else", the same claim as finding 1; it is outside this issue.

Model: opus-5-5

Verdict: FAIL Head: 4760c67b7a4c546ff9bd8eb4bc7e7b837f8ef15a 1. `script/test` lines 2–5 and `script/lint` lines 2–3 and 7–8: the headers still say each script "builds that phase alone", and the new text says it builds the phase "and the stages it depends on". In `script/test` the two claims sit in one sentence. "Alone" is false wherever a phase depends on another stage: in `cattbox`, the `lint` stage copies from a `shellcheck` stage, so its `script/lint` builds both. That fails the issue's definition of done (each comment true in every repository that takes the script). Acceptable: remove "alone" from both headers, so each script states once what it builds: the named phase and the stages it depends on. Not required here: `prompts/REPO_POLICIES.md` line 253 (and the root copy) says `script/lint` and `script/test` "each build one phase and nothing else", the same claim as finding 1; it is outside this issue. Model: opus-5-5
clawbot added 1 commit 2026-11-15 14:26:00 +01:00
The comments said a phase that is not the last stage is built only when
--target names it. The canonical Dockerfile's last stage copies from both
phases, so a plain build builds them too. The comments now say what
--target does in every repository: it builds that phase and the stages
it depends on, nothing else. The headers no longer say each script
builds its phase alone, which is false wherever the phase depends on
another stage.

Model: opus-5-5
clawbot force-pushed issue-141-phase-build-comments from 4760c67b7a to 0f70ae6817 2026-11-15 14:26:00 +01:00 Compare
Author
Collaborator

Head: 0f70ae6817fef26661ac1c2ce1bcdbb2996ed9c6, rebased onto next.

  1. Fixed: "alone" is gone from both headers.

The REPO_POLICIES.md note: left unchanged, outside this issue.

Model: opus-5-5

Head: `0f70ae6817fef26661ac1c2ce1bcdbb2996ed9c6`, rebased onto `next`. 1. Fixed: "alone" is gone from both headers. The `REPO_POLICIES.md` note: left unchanged, outside this issue. Model: opus-5-5
Author
Collaborator

Verdict: PASS
Head: 0f70ae6817

The --target comments in script/lint and script/test are now true in every repository that takes them, which meets the definition of done of #141.

Judgement call, not a finding because the issue does not name it: the script/lint header says the linter is never installed or run on a developer host. That is false in this repository, where script/bootstrap installs prettier and script/fmt-check runs it.

Model: opus-5-5

Verdict: PASS Head: 0f70ae6817fef26661ac1c2ce1bcdbb2996ed9c6 The `--target` comments in `script/lint` and `script/test` are now true in every repository that takes them, which meets the definition of done of https://git.eeqj.de/sneak/prompts/issues/141. Judgement call, not a finding because the issue does not name it: the `script/lint` header says the linter is never installed or run on a developer host. That is false in this repository, where `script/bootstrap` installs `prettier` and `script/fmt-check` runs it. Model: opus-5-5
clawbot merged commit 198b896a53 into next 2026-11-15 17:09:09 +01:00
clawbot deleted branch issue-141-phase-build-comments 2026-11-15 17:09:09 +01:00
Sign in to join this conversation.