script/install-precommit: write the hook through $hook (closes #139) #172

Merged
clawbot merged 1 commits from issue-139-install-precommit-hook-var into next 2026-11-15 14:23:52 +01:00
Collaborator

script/install-precommit set hook=".git/hooks/pre-commit" and then wrote and chmodded the path literally, so shellcheck reported hook as unused (SC2034). It now writes and chmods through "$hook"; behaviour is unchanged.

This repository holds one copy of the script, so the byte-identical requirement holds trivially. Repos that vendor it, such as cattbox (sneak/cattbox#56), can drop their local fix at their next re-vendor.

Disclosure: no test added. This repository's lint does not run shellcheck, and adding it is outside this issue.

closes #139

Model: opus-5-5

`script/install-precommit` set `hook=".git/hooks/pre-commit"` and then wrote and chmodded the path literally, so shellcheck reported `hook` as unused (SC2034). It now writes and chmods through `"$hook"`; behaviour is unchanged. This repository holds one copy of the script, so the byte-identical requirement holds trivially. Repos that vendor it, such as cattbox (https://git.eeqj.de/sneak/cattbox/pulls/56), can drop their local fix at their next re-vendor. Disclosure: no test added. This repository's lint does not run shellcheck, and adding it is outside this issue. closes https://git.eeqj.de/sneak/prompts/issues/139 Model: opus-5-5
clawbot added the needs-review label 2026-11-15 13:59:12 +01:00
clawbot self-assigned this 2026-11-15 13:59:12 +01:00
clawbot added 1 commit 2026-11-15 13:59:12 +01:00
The script set hook and then repeated the path literally, so shellcheck
reported the variable as unused (SC2034).

Model: opus-5-5
Author
Collaborator

Verdict: PASS
Head: badac32cd3

Meets the definition of done in #139 with no other change.

Model: opus-5-5

Verdict: PASS Head: badac32cd3ba7fd2c355de545e266bee1a37f683 Meets the definition of done in https://git.eeqj.de/sneak/prompts/issues/139 with no other change. Model: opus-5-5
clawbot merged commit 11245b85ca into next 2026-11-15 14:23:52 +01:00
clawbot deleted branch issue-139-install-precommit-hook-var 2026-11-15 14:23:52 +01:00
Sign in to join this conversation.