Canonical script/install-precommit sets hook and never uses it, which shellcheck rejects #139

New Issue

2026-11-02T10:44:46+01:00

clawbot commented

2026-11-02 10:44:46 +01:00

The canonical script/install-precommit (at next, 430964c) sets hook=".git/hooks/pre-commit" and then writes and chmods .git/hooks/pre-commit literally, so the variable is never used. shellcheck reports it (SC2034, hook appears unused), so any repository that runs shellcheck over script/ cannot take the file unchanged.

Found in the cattbox re-vendor, sneak/cattbox#56, which carries the fix as a disclosed deviation and would drop it at its next re-vendor once this lands.

Definition of done

script/install-precommit writes and chmods the hook through "$hook", so shellcheck reports nothing for it.
Every copy of that script in this repository stays byte-identical.

Model: opus-5-5

The canonical `script/install-precommit` (at `next`, `430964c`) sets `hook=".git/hooks/pre-commit"` and then writes and chmods `.git/hooks/pre-commit` literally, so the variable is never used. shellcheck reports it (SC2034, `hook` appears unused), so any repository that runs shellcheck over `script/` cannot take the file unchanged. Found in the cattbox re-vendor, https://git.eeqj.de/sneak/cattbox/pulls/56, which carries the fix as a disclosed deviation and would drop it at its next re-vendor once this lands. ## Definition of done - `script/install-precommit` writes and chmods the hook through `"$hook"`, so shellcheck reports nothing for it. - Every copy of that script in this repository stays byte-identical. Model: opus-5-5

clawbot referenced this issue

2026-11-04 03:28:35 +01:00

next → main: version from git, runtimes from the distribution, yarn 4 in the tree, golangci-lint v2.15.0, Dockerfile and ignore-file fixes #68

clawbot referenced this issue

2026-11-04 09:56:44 +01:00

next → main: version from git, runtimes from the distribution, yarn 4 in the tree, golangci-lint v2.15.0, Dockerfile and ignore-file fixes #68

clawbot referenced this issue

2026-11-04 18:44:59 +01:00

question: yarn 1 lockfiles against the newest Debian and Ubuntu, which package yarn 4 #149

clawbot referenced this issue

2026-11-04 21:33:33 +01:00

next → main: version from git, runtimes from the distribution, yarn 4 in the tree, golangci-lint v2.15.0, Dockerfile and ignore-file fixes #68