Correct the phase-build comments in script/lint and script/test (closes #141)
check / check (push) Successful in 23s

The comments said a phase that is not the last stage is built only when
--target names it. The canonical Dockerfile's last stage copies from both
phases, so a plain build builds them too. The comments now say what
--target does in every repository: it builds that phase and the stages
it depends on, nothing else.

Model: opus-5-5
This commit is contained in:
sneak committed 2026-11-15 12:59:12 +00:00
1 parent 02632a5682
commit 4760c67b7a
2 files changed
+4 -4

No files matched your search

+2 -2
View File
@@ -4,8 +4,8 @@
# a developer host, where a shared result cache and a host-global lock # a developer host, where a shared result cache and a host-global lock
# make its answer untrustworthy. # make its answer untrustworthy.
# #
# The phase is not the last stage in the file, so it is built only when # --target builds the lint phase and the stages it depends on, nothing
# --target names it. A new CACHEBUST value reruns every RUN step after # else. A new CACHEBUST value reruns every RUN step after
# the ARG CACHEBUST line, since a cached lint layer is a lint that did # the ARG CACHEBUST line, since a cached lint layer is a lint that did
# not run; unlike --no-cache, it keeps the layers above that line and # not run; unlike --no-cache, it keeps the layers above that line and
# the cache mounts. This relies on every stage of the Dockerfile # the cache mounts. This relies on every stage of the Dockerfile
+2 -2
View File
@@ -1,8 +1,8 @@
#!/bin/sh #!/bin/sh
# script/test: run the test suite. Testing is a phase of the Dockerfile # script/test: run the test suite. Testing is a phase of the Dockerfile
# and this builds that phase alone, on the same terms as script/lint: # and this builds that phase alone, on the same terms as script/lint:
# --target because a phase that is not the last stage is built only when # --target so that only the test phase and the stages it depends on are
# named, and a new CACHEBUST value because a cached test layer is a test # built, and a new CACHEBUST value because a cached test layer is a test
# that did not run; unlike --no-cache, it keeps the layers above the ARG # that did not run; unlike --no-cache, it keeps the layers above the ARG
# CACHEBUST line and the cache mounts. This relies on every stage of the # CACHEBUST line and the cache mounts. This relies on every stage of the
# Dockerfile declaring ARG CACHEBUST before every step that lints, tests # Dockerfile declaring ARG CACHEBUST before every step that lints, tests