From 4760c67b7a4c546ff9bd8eb4bc7e7b837f8ef15a Mon Sep 17 00:00:00 2001 From: sneak Date: Sun, 15 Nov 2026 12:59:12 +0000 Subject: [PATCH] Correct the phase-build comments in script/lint and script/test (closes #141) The comments said a phase that is not the last stage is built only when --target names it. The canonical Dockerfile's last stage copies from both phases, so a plain build builds them too. The comments now say what --target does in every repository: it builds that phase and the stages it depends on, nothing else. Model: opus-5-5 --- script/lint | 4 ++-- script/test | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/script/lint b/script/lint index 451a067..aadcc15 100755 --- a/script/lint +++ b/script/lint @@ -4,8 +4,8 @@ # a developer host, where a shared result cache and a host-global lock # make its answer untrustworthy. # -# The phase is not the last stage in the file, so it is built only when -# --target names it. A new CACHEBUST value reruns every RUN step after +# --target builds the lint phase and the stages it depends on, nothing +# else. A new CACHEBUST value reruns every RUN step after # the ARG CACHEBUST line, since a cached lint layer is a lint that did # not run; unlike --no-cache, it keeps the layers above that line and # the cache mounts. This relies on every stage of the Dockerfile diff --git a/script/test b/script/test index 1622a11..c629522 100755 --- a/script/test +++ b/script/test @@ -1,8 +1,8 @@ #!/bin/sh # script/test: run the test suite. Testing is a phase of the Dockerfile # and this builds that phase alone, on the same terms as script/lint: -# --target because a phase that is not the last stage is built only when -# named, and a new CACHEBUST value because a cached test layer is a test +# --target so that only the test phase and the stages it depends on are +# built, and a new CACHEBUST value because a cached test layer is a test # that did not run; unlike --no-cache, it keeps the layers above the ARG # CACHEBUST line and the cache mounts. This relies on every stage of the # Dockerfile declaring ARG CACHEBUST before every step that lints, tests