Every start prints about 65 lines of the dependency-injection library's own log, and a startup error twice #359

New Issue

2026-11-11T21:13:26+01:00

clawbot commented

2026-11-11 21:13:26 +01:00

Found in the hands-on acceptance test of next (092176d), #356.

Steps

Start pixad, from ./bin/pixad --config config.yml or the Docker image, and stop it.
Start it with an invalid setting, for example PIXA_SIGNING_KEY=short.

What happened

Every start writes about 65 lines like [Fx] PROVIDE *config.Config <= sneak.berlin/go/pixa/internal/config.New() to stderr. Every stop writes about 20 [Fx] HOOK OnStop ... lines. docker logs mixes them with pixa's JSON log lines.
A startup error is printed twice. Each copy is wrapped in the library's frames (failed to build *config.Config: received non-nil error from function ... could not build arguments for function ...). The one useful line is buried among them: config key "signing_key" (environment variable PIXA_SIGNING_KEY): value too short: must be at least 32 characters, got 5.

The lines come from fx, the dependency-injection library. internal/app/app.go builds the fx app without fx.WithLogger, so fx writes its own event log.

What should happen

pixa's output holds only pixa's own log lines (slog, as README Architecture says).
A startup error is printed once, as the one line that names the setting, and pixa exits with status 1 as now.

Trap: fx.NopLogger alone also hides the startup error, since fx reports it through that logger. pixa must then print the error itself, for example from app.Err().

Model: opus-5-5

Found in the hands-on acceptance test of `next` (`092176d`), https://git.eeqj.de/sneak/pixa/issues/356. ## Steps 1. Start `pixad`, from `./bin/pixad --config config.yml` or the Docker image, and stop it. 2. Start it with an invalid setting, for example `PIXA_SIGNING_KEY=short`. ## What happened - Every start writes about 65 lines like `[Fx] PROVIDE *config.Config <= sneak.berlin/go/pixa/internal/config.New()` to stderr. Every stop writes about 20 `[Fx] HOOK OnStop ...` lines. `docker logs` mixes them with pixa's JSON log lines. - A startup error is printed twice. Each copy is wrapped in the library's frames (`failed to build *config.Config: received non-nil error from function ... could not build arguments for function ...`). The one useful line is buried among them: `config key "signing_key" (environment variable PIXA_SIGNING_KEY): value too short: must be at least 32 characters, got 5`. The lines come from `fx`, the dependency-injection library. `internal/app/app.go` builds the `fx` app without `fx.WithLogger`, so `fx` writes its own event log. ## What should happen - pixa's output holds only pixa's own log lines (`slog`, as README Architecture says). - A startup error is printed once, as the one line that names the setting, and pixa exits with status 1 as now. Trap: `fx.NopLogger` alone also hides the startup error, since `fx` reports it through that logger. pixa must then print the error itself, for example from `app.Err()`. Model: opus-5-5

clawbot referenced this issue

2026-11-11 21:14:17 +01:00

Acceptance test: use pixa end to end as a user before a release candidate #356

clawbot referenced this issue from a commit

2026-11-11 21:31:00 +01:00

Test that pixad writes only its own errors to stderr (closes #359)

clawbot referenced this issue from a commit

2026-11-11 21:33:11 +01:00

Test that pixad writes only its own errors to stderr (closes #359)

clawbot referenced this issue from a commit

2026-11-11 21:34:06 +01:00

Print a startup or shutdown error once, without fx's event log (closes #359)

clawbot referenced a pull request that will close this issue

2026-11-11 21:34:15 +01:00

Print startup errors once and drop the fx event log (closes #359) #366

clawbot commented

2026-11-11 21:34:19 +01:00

PR: #366, branch issue-359-quiet-fx-log, base next.

pixad builds the fx app with fx.NopLogger and runs start, wait and stop itself. It prints a start or stop error once, through dig.RootCause, and exits 1 as before. Two commits: failing tests first, then the fix.

Model: opus-5-5

PR: https://git.eeqj.de/sneak/pixa/pulls/366, branch `issue-359-quiet-fx-log`, base `next`. pixad builds the `fx` app with `fx.NopLogger` and runs start, wait and stop itself. It prints a start or stop error once, through `dig.RootCause`, and exits 1 as before. Two commits: failing tests first, then the fix. Model: opus-5-5

clawbot referenced this issue from a commit

2026-11-11 22:00:33 +01:00

Test that pixad writes only its own errors to stderr (closes #359)

clawbot referenced this issue from a commit

2026-11-11 22:00:33 +01:00

Print a startup or shutdown error once, without fx's event log (closes #359)

clawbot referenced this issue from a commit

2026-11-11 22:02:45 +01:00

Print a startup or shutdown error once, without fx's event log (closes #359)

clawbot referenced this issue from a commit

2026-11-11 22:26:52 +01:00

Test that pixad writes only its own errors to stderr (closes #359)