script/docker-smoke: the comment on --health-interval describes old Docker behavior #132

Closed
opened 2026-09-28 12:07:44 +02:00 by clawbot · 1 comment
Collaborator

Found in review of #130.

script/docker-smoke passes --health-interval=1s, and its comment says the image's 30s interval would otherwise use up the whole 30-second wait. That holds only on Docker older than 25. From Docker 25 on, probes during the start period run at the start interval (default 5s), so the first probe comes about 5 seconds in with or without the flag. The flag still matters when the service starts slowly, because failed probes are then retried every second instead of every 30.

Definition of done

  • The comment says what the flag does on current Docker, in one or two plain sentences; or the script uses --health-start-interval=1s, which targets the start-up probes directly, if the Docker versions the script must support all have it (say which in the PR).
  • Only script/docker-smoke changes. make docker-smoke still passes.

Model: opus-5-5

Found in review of https://git.eeqj.de/sneak/pixa/pulls/130. `script/docker-smoke` passes `--health-interval=1s`, and its comment says the image's 30s interval would otherwise use up the whole 30-second wait. That holds only on Docker older than 25. From Docker 25 on, probes during the start period run at the start interval (default 5s), so the first probe comes about 5 seconds in with or without the flag. The flag still matters when the service starts slowly, because failed probes are then retried every second instead of every 30. ## Definition of done - The comment says what the flag does on current Docker, in one or two plain sentences; or the script uses `--health-start-interval=1s`, which targets the start-up probes directly, if the Docker versions the script must support all have it (say which in the PR). - Only `script/docker-smoke` changes. `make docker-smoke` still passes. Model: opus-5-5
clawbot added this to the 1.0.0 milestone 2026-09-28 12:07:44 +02:00
Author
Collaborator

Reworded the comment in script/docker-smoke, keeping --health-interval=1s: from Docker 25 on, the first probe comes about 5 seconds in either way, and the flag makes probes after the 10-second start period come every second instead of every 30. Checked on Docker 29.8.0. PR: #137

Model: opus-5-5

Reworded the comment in `script/docker-smoke`, keeping `--health-interval=1s`: from Docker 25 on, the first probe comes about 5 seconds in either way, and the flag makes probes after the 10-second start period come every second instead of every 30. Checked on Docker 29.8.0. PR: https://git.eeqj.de/sneak/pixa/pulls/137 Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/pixa#132