Remove Buildarch: read the architecture at run time (closes #83) #84

Merged
clawbot merged 1 commits from issue-83-remove-buildarch into next 2026-10-02 01:05:09 +02:00
Collaborator

Implements #83, following sneak/prompts#66.

The architecture is no longer passed in at build time:

  • main.go and globals: the Buildarch variable and field are removed, not left empty.
  • logger.Identify and the listen log line in server/http.go report runtime.GOARCH under the key arch in place of buildarch.
  • backend/script/build drops -X main.Buildarch=$(uname -m) and its header's mention of the architecture; the Dockerfile comment quoting the build command drops it too.

Worth knowing: the log key changes from buildarch to arch, and the value changes from uname -m naming (x86_64, aarch64) to Go naming (amd64, arm64). Anything that filters logs on the old key or values would need updating; nothing in this repo does.

Deviation: backend/README.md is not in the issue's file list, but it said the build stamps in the architecture, which the definition of done rules out, so that one sentence is changed.

Judgement call: the globals package comment still describes build-time values; it stays true for Appname and Version, so it is unchanged.

Model: opus-5-5

Implements https://git.eeqj.de/sneak/netwatch/issues/83, following https://git.eeqj.de/sneak/prompts/issues/66. The architecture is no longer passed in at build time: - `main.go` and `globals`: the `Buildarch` variable and field are removed, not left empty. - `logger.Identify` and the listen log line in `server/http.go` report `runtime.GOARCH` under the key `arch` in place of `buildarch`. - `backend/script/build` drops `-X main.Buildarch=$(uname -m)` and its header's mention of the architecture; the `Dockerfile` comment quoting the build command drops it too. Worth knowing: the log key changes from `buildarch` to `arch`, and the value changes from `uname -m` naming (`x86_64`, `aarch64`) to Go naming (`amd64`, `arm64`). Anything that filters logs on the old key or values would need updating; nothing in this repo does. Deviation: `backend/README.md` is not in the issue's file list, but it said the build stamps in the architecture, which the definition of done rules out, so that one sentence is changed. Judgement call: the `globals` package comment still describes build-time values; it stays true for `Appname` and `Version`, so it is unchanged. Model: opus-5-5
clawbot added the needs-review label 2026-10-02 00:53:22 +02:00
clawbot self-assigned this 2026-10-02 00:53:22 +02:00
clawbot added 1 commit 2026-10-02 00:53:23 +02:00
The architecture is no longer passed in at build time. The Buildarch
variable and field are gone from main and globals, script/build no
longer stamps it in with -X, and the startup and listen log lines
report runtime.GOARCH under the key "arch". The Dockerfile comment and
backend/README.md no longer describe an architecture being stamped in.

Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit e6d6815ecb into next 2026-10-02 01:05:09 +02:00
clawbot deleted branch issue-83-remove-buildarch 2026-10-02 01:05:10 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/netwatch#84