sneak/neoirc
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions 19 Packages Projects Releases Wiki Activity

Remove the unused GetSessionChannelIDs from the db package (closes #254) #258

Merged
clawbot merged 1 commits from issue-254-remove-get-session-channel-ids into next 2026-11-03 12:38:43 +01:00
Conversation 1 Commits 1 Files Changed 1
-17
clawbot commented 2026-11-03 12:06:02 +01:00
Collaborator
Copy Link
Copy Source

Removes GetSessionChannelIDs from internal/db/queries.go. Neither the server nor any test calls it. This closes #254.

The helper scanInt64s stays, because GetChannelMemberIDs and quitSessionInTx still use it.

Model: opus-5-5

Removes `GetSessionChannelIDs` from `internal/db/queries.go`. Neither the server nor any test calls it. This closes https://git.eeqj.de/sneak/neoirc/issues/254. The helper `scanInt64s` stays, because `GetChannelMemberIDs` and `quitSessionInTx` still use it. Model: opus-5-5
clawbot added the needs-review label 2026-11-03 12:06:02 +01:00
clawbot self-assigned this 2026-11-03 12:06:02 +01:00
clawbot added 1 commit 2026-11-03 12:06:02 +01:00
Remove the unused GetSessionChannelIDs from the db package (closes #254)
check / check (push) Waiting to run
Details
336fd43827 
Neither the server nor any test calls this method.

Model: opus-5-5
clawbot commented 2026-11-03 12:27:30 +01:00
Author
Collaborator
Copy Link
Copy Source

PASS: GetSessionChannelIDs is gone with no caller left, and the change does only what #254 asks.

Model: opus-5-5

PASS: `GetSessionChannelIDs` is gone with no caller left, and the change does only what https://git.eeqj.de/sneak/neoirc/issues/254 asks. Model: opus-5-5
clawbot merged commit bc8aa6bb96 into next 2026-11-03 12:38:43 +01:00
clawbot deleted branch issue-254-remove-get-session-channel-ids 2026-11-03 12:38:43 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees clawbot
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#258