sneak/neoirc
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

fix: correct golangci-lint v2 module path in Dockerfile (closes #13) #20

Closed
clawbot wants to merge 1 commits from fix/dockerfile-golangci-lint-v2-module-path into main
pull from: fix/dockerfile-golangci-lint-v2-module-path
merge into: :main
Conversation 3 Commits 1 Files Changed 1
+1 -1
clawbot commented 2026-02-27 05:47:01 +01:00
Collaborator
Copy Link
Copy Source

Summary

One-line fix: correct the go install module path for golangci-lint v2 in the Dockerfile.

Change

-RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v2.1.6
+RUN CGO_ENABLED=0 go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6

Why

  • golangci-lint v2 moved to module path github.com/golangci/golangci-lint/v2/...
  • CGO_ENABLED=0 is needed because the Docker build uses Alpine (no glibc)

Scope

This PR only fixes the golangci-lint install step. Pre-existing lint failures in make check are out of scope.

Closes #13

## Summary One-line fix: correct the `go install` module path for golangci-lint v2 in the Dockerfile. ### Change ```diff -RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v2.1.6 +RUN CGO_ENABLED=0 go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 ``` ### Why - golangci-lint v2 moved to module path `github.com/golangci/golangci-lint/v2/...` - `CGO_ENABLED=0` is needed because the Docker build uses Alpine (no glibc) ### Scope This PR **only** fixes the golangci-lint install step. Pre-existing lint failures in `make check` are out of scope. Closes #13
sneak was assigned by clawbot 2026-02-27 05:47:01 +01:00
clawbot added 1 commit 2026-02-27 05:47:02 +01:00
fix: correct golangci-lint v2 module path in Dockerfile
check / check (push) Failing after 1m19s
Details
f821d66670 
golangci-lint v2 uses module path github.com/golangci/golangci-lint/v2/...
Also set CGO_ENABLED=0 for Alpine compatibility.

Closes #13
clawbot commented 2026-02-27 05:47:09 +01:00
Author
Collaborator
Copy Link
Copy Source

This PR makes a single-line change to fix the golangci-lint install in the Dockerfile.

What changed: The module path was updated from .../golangci-lint/cmd/... to .../golangci-lint/v2/cmd/... (required for v2), and CGO_ENABLED=0 was added for Alpine compatibility.

What this does NOT do: No Go source files, no .golangci.yml, no lint fixes. The make check step will still fail due to pre-existing lint issues — that is a separate issue.

This is a clean redo of the Dockerfile fix from PR #19, with no out-of-scope changes.

This PR makes a single-line change to fix the golangci-lint install in the Dockerfile. **What changed:** The module path was updated from `.../golangci-lint/cmd/...` to `.../golangci-lint/v2/cmd/...` (required for v2), and `CGO_ENABLED=0` was added for Alpine compatibility. **What this does NOT do:** No Go source files, no `.golangci.yml`, no lint fixes. The `make check` step will still fail due to pre-existing lint issues — that is a separate issue. This is a clean redo of the Dockerfile fix from PR #19, with no out-of-scope changes.
clawbot commented 2026-02-27 07:21:55 +01:00
Author
Collaborator
Copy Link
Copy Source

Superseded by PR #10 which included this fix. Closing.

Superseded by PR #10 which included this fix. Closing.
clawbot closed this pull request 2026-02-27 07:21:56 +01:00
clawbot commented 2026-02-27 07:26:34 +01:00
Author
Collaborator
Copy Link
Copy Source

Superseded by the Dockerfile fix in PR #10 (commit f54a3fc). Closing.

Superseded by the Dockerfile fix in PR #10 (commit f54a3fc). Closing.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#20