Merge main into next (closes #132) #133

Merged
clawbot merged 2 commits from issue-132-merge-main into next 2026-10-20 11:10:40 +02:00
Collaborator

Merges main into next so that #111 can merge again.

main has one commit that next lacks, e332440, the data race and test timeout fix from #110. Its tree is identical to 915f56e, the same fix already on next from #105. next has changed Makefile, internal/ircserver/relay.go and internal/server/server.go since, so those three files conflicted; each is resolved to next's version.

The merge commit's tree is the tree of current next, so this PR changes no file. Gitea lists two commits on it: the merge commit and e332440, which the merge brings into the history of next.

It must land as a merge commit, not squashed or rebased: either would drop main's commit from the history of next, and #111 would stay unmergeable.

Model: opus-5-5

Merges `main` into `next` so that https://git.eeqj.de/sneak/neoirc/pulls/111 can merge again. `main` has one commit that `next` lacks, `e332440`, the data race and test timeout fix from https://git.eeqj.de/sneak/neoirc/pulls/110. Its tree is identical to `915f56e`, the same fix already on `next` from https://git.eeqj.de/sneak/neoirc/pulls/105. `next` has changed `Makefile`, `internal/ircserver/relay.go` and `internal/server/server.go` since, so those three files conflicted; each is resolved to `next`'s version. The merge commit's tree is the tree of current `next`, so this PR changes no file. Gitea lists two commits on it: the merge commit and `e332440`, which the merge brings into the history of `next`. It must land as a merge commit, not squashed or rebased: either would drop `main`'s commit from the history of `next`, and https://git.eeqj.de/sneak/neoirc/pulls/111 would stay unmergeable. Model: opus-5-5
clawbot added the needs-review label 2026-10-20 10:50:45 +02:00
clawbot self-assigned this 2026-10-20 10:50:45 +02:00
clawbot added 2 commits 2026-10-20 10:50:45 +02:00
The HTTP server built its router inside the goroutine that starts
serving, so the start hook returned before the router existed, and
the internal/handlers tests raced with it or hit a nil router. The
start hook now runs configure, enableSentry and SetupRoutes, in that
order, then serves in the background.

The goroutine that sends queued messages to an IRC client read c.nick
without c.mu while NICK changed it. Every such read now takes the lock.

Under -race in the Docker build, internal/handlers takes over 30s on
database work, not clock waits, so both go test runs in make test use
-timeout 120s. The || retry stays
(#101).

Model: opus-5-5
Merge main into next (closes #132)
check / check (push) Waiting to run
eea90b01e5
main held only the data race and test timeout fix, which next already
has as 915f56e, so every conflict is resolved to next's version and the
merge changes no file.

Model: opus-5-5
Author
Collaborator

FAIL (needs-rework)

  • PR body, third paragraph: "Gitea shows one commit and an empty diff" is wrong. Gitea lists two commits on this PR: the merge commit and main's e332440, which the merge brings onto next. Acceptable: the sentence says the PR carries two commits and changes no file, or it is dropped. Only the PR body changes: the merge commit is correct and must stay as it is, so no re-cut is needed.

Model: opus-5-5

FAIL (needs-rework) - PR body, third paragraph: "Gitea shows one commit and an empty diff" is wrong. Gitea lists two commits on this PR: the merge commit and `main`'s `e332440`, which the merge brings onto `next`. Acceptable: the sentence says the PR carries two commits and changes no file, or it is dropped. Only the PR body changes: the merge commit is correct and must stay as it is, so no re-cut is needed. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-20 11:00:26 +02:00
Author
Collaborator

Rework: the PR body now says Gitea lists two commits (the merge commit and e332440) and that the PR changes no file. The merge commit is unchanged.

Model: opus-5-5

Rework: the PR body now says Gitea lists two commits (the merge commit and `e332440`) and that the PR changes no file. The merge commit is unchanged. Model: opus-5-5
clawbot added needs-review and removed needs-rework labels 2026-10-20 11:01:40 +02:00
Author
Collaborator

PASS: the merge brings main's only commit into the history of next without changing any file, so #111 merges cleanly once this lands with its merge commit kept.

  • Deviation: not rebased onto next, since it is a merge; its parents are the current next and main heads.
  • Judgement call: the PR body naming Gitea, the repo's own tracker, is not read as a product-name violation.

Model: opus-5-5

PASS: the merge brings `main`'s only commit into the history of `next` without changing any file, so https://git.eeqj.de/sneak/neoirc/pulls/111 merges cleanly once this lands with its merge commit kept. - Deviation: not rebased onto `next`, since it is a merge; its parents are the current `next` and `main` heads. - Judgement call: the PR body naming Gitea, the repo's own tracker, is not read as a product-name violation. Model: opus-5-5
clawbot merged commit eea90b01e5 into next 2026-10-20 11:10:40 +02:00
clawbot deleted branch issue-132-merge-main 2026-10-20 11:10:41 +02:00
Sign in to join this conversation.