sneak/neoirc
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

neoirc-cli shows connected in the status bar after /query while not connected #235

New Issue
Closed
opened 2026-11-02 03:05:34 +01:00 by clawbot · 1 comment
clawbot commented 2026-11-02 03:05:34 +01:00
Collaborator
Copy Link
Copy Source

In neoirc-cli, cmdQuery in internal/cli/app.go always sets the status bar to [connected]. Typing /query erin before /connect makes the status bar say [connected] while the client has no session. /window had the same fault, fixed by #234 for #225; the other commands that set [connected] only do so while connected. Found by the worker on that PR; read from the code on 6387d68.

Fix: /query shows [connected] only while the client is connected and [disconnected] otherwise, reading a.connected under a.mu as /window now does. Change nothing else.

Definition of done

  1. Before /connect, /query erin leaves the status bar showing [disconnected].
  2. While connected, it shows [connected] as before.
  3. A test in internal/cli for both.
  4. One reviewed PR against next, cut after #225 has landed.

Model: opus-5-5

In `neoirc-cli`, `cmdQuery` in `internal/cli/app.go` always sets the status bar to `[connected]`. Typing `/query erin` before `/connect` makes the status bar say `[connected]` while the client has no session. `/window` had the same fault, fixed by https://git.eeqj.de/sneak/neoirc/pulls/234 for https://git.eeqj.de/sneak/neoirc/issues/225; the other commands that set `[connected]` only do so while connected. Found by the worker on that PR; read from the code on `6387d68`. Fix: `/query` shows `[connected]` only while the client is connected and `[disconnected]` otherwise, reading `a.connected` under `a.mu` as `/window` now does. Change nothing else. ## Definition of done 1. Before `/connect`, `/query erin` leaves the status bar showing `[disconnected]`. 2. While connected, it shows `[connected]` as before. 3. A test in `internal/cli` for both. 4. One reviewed PR against `next`, cut after https://git.eeqj.de/sneak/neoirc/issues/225 has landed. Model: opus-5-5
clawbot commented 2026-11-02 05:54:56 +01:00
Author
Collaborator
Copy Link
Copy Source

/query now shows [connected] only while the client is connected, and [disconnected] otherwise, as /window does. The fix and its test are in #244.

Model: opus-5-5

`/query` now shows `[connected]` only while the client is connected, and `[disconnected]` otherwise, as `/window` does. The fix and its test are in https://git.eeqj.de/sneak/neoirc/pulls/244. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/neoirc#235