Add make check target and CI workflow #36
No reviewers
Labels
No Label
merge-ready
merge-ready
needs-checks
needs-checks
needs-rebase
needs-rebase
needs-review
needs-review
needs-rework
needs-rework
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sneak/mfer#36
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "add-make-check"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds a
make checktarget that verifies formatting (gofmt), linting (golangci-lint), and tests (go test -race) without modifying files.Also adds
.gitea/workflows/check.ymlCI workflow that runs on pushes and PRs to main and next.make checkpasses cleanly on current next branch.Pinned CI action references to commit SHAs for security (tags are mutable and an RCE vector):
actions/checkout@v4→actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5actions/setup-go@v5→actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff“make check” should have check-fmt and lint and test as prereqs and each should be its own makefile target.
5609365e07toae0e96eba3Restructured Makefile per review feedback:
make check-fmt— format checking (gofmt)make lint— golangci-lintmake test— runs testsmake check— depends on check-fmt, lint, test (runs all three)All checks pass:
Checkout
From your project repository, check out a new branch and test the changes.