Log failed files at error level so check -q shows them (closes #195) #200

Merged
clawbot merged 1 commits from issue-195-check-quiet-failures into next 2026-10-13 16:46:14 +02:00
Collaborator

check -q printed nothing about a failed file: each one was logged at info level and -q shows errors only, so the exit status was the only sign the check failed.

check now logs each failed file (MISSING, SIZE_MISMATCH, HASH_MISMATCH, MODE_MISMATCH, ERROR) at error level, and also each file the manifest does not list (EXTRA) when --no-extra-files makes it a failure. Without --no-extra-files such a file stays a warning, which -q hides, as #103 settled. The closing N failed summary stays at info level.

Not visible in the diff: error-level lines carry the error symbol (red on a terminal) instead of the info bullet, so a failed file now looks like an error with or without -q.

Fixes #195

Model: opus-5-5

`check -q` printed nothing about a failed file: each one was logged at info level and `-q` shows errors only, so the exit status was the only sign the check failed. `check` now logs each failed file (`MISSING`, `SIZE_MISMATCH`, `HASH_MISMATCH`, `MODE_MISMATCH`, `ERROR`) at error level, and also each file the manifest does not list (`EXTRA`) when `--no-extra-files` makes it a failure. Without `--no-extra-files` such a file stays a warning, which `-q` hides, as https://git.eeqj.de/sneak/mfer/issues/103 settled. The closing `N failed` summary stays at info level. Not visible in the diff: error-level lines carry the error symbol (red on a terminal) instead of the info bullet, so a failed file now looks like an error with or without `-q`. Fixes https://git.eeqj.de/sneak/mfer/issues/195 Model: opus-5-5
clawbot added the needs-review label 2026-10-13 15:18:31 +02:00
clawbot self-assigned this 2026-10-13 15:18:31 +02:00
clawbot added 1 commit 2026-10-13 15:18:32 +02:00
check logged each failed file at info level, and -q shows errors only,
so `check -q` reported a failure through its exit status alone. Each
failed file, and each file the manifest does not list under
--no-extra-files, is now logged at error level. A file the manifest
does not list stays a warning without --no-extra-files, and the closing
summary stays at info level.

Model: opus-5-5
Author
Collaborator

Review passed.

  • Judgement call: failed files now show the error symbol instead of the info bullet. That comes with logging them at error level, as #195 asks, and matches the README's "displaying error".
  • Judgement call: the new assertion in TestCheckWarnsAboutUnlistedFiles covers the --no-extra-files case the issue names, so it is in scope.

Model: opus-5-5

Review passed. - Judgement call: failed files now show the error symbol instead of the info bullet. That comes with logging them at error level, as https://git.eeqj.de/sneak/mfer/issues/195 asks, and matches the README's "displaying error". - Judgement call: the new assertion in `TestCheckWarnsAboutUnlistedFiles` covers the `--no-extra-files` case the issue names, so it is in scope. Model: opus-5-5
clawbot merged commit f68cc284ac into next 2026-10-13 16:46:14 +02:00
clawbot deleted branch issue-195-check-quiet-failures 2026-10-13 16:46:15 +02:00
Sign in to join this conversation.