1.0 quality polish — code review, tests, bug fixes, documentation (#32)

Comprehensive quality pass targeting 1.0 release: - Code review and refactoring - Fix open bugs (#14, #16, #23) - Expand test coverage - Lint clean - README update with build instructions (#9) - Documentation improvements Branched from `next` (active dev branch). Reviewed-on: #32 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
2026-03-01 23:58:37 +01:00
parent bbab6e73f4
commit 43916c7746
25 changed files with 1021 additions and 189 deletions
@@ -70,6 +70,8 @@ type Checker struct {
 	fs       afero.Fs
 	// manifestPaths is a set of paths in the manifest for quick lookup
 	manifestPaths map[RelFilePath]struct{}
+	// manifestRelPath is the relative path of the manifest file from basePath (for exclusion)
+	manifestRelPath RelFilePath
 	// signature info from the manifest
 	signature     []byte
 	signer        []byte
@@ -100,14 +102,25 @@ func NewChecker(manifestPath string, basePath string, fs afero.Fs) (*Checker, er
 		manifestPaths[RelFilePath(f.Path)] = struct{}{}
 	}

+	// Compute manifest's relative path from basePath for exclusion in FindExtraFiles
+	absManifest, err := filepath.Abs(manifestPath)
+	if err != nil {
+		return nil, err
+	}
+	manifestRel, err := filepath.Rel(abs, absManifest)
+	if err != nil {
+		manifestRel = ""
+	}
+
 	return &Checker{
-		basePath:      AbsFilePath(abs),
-		files:         files,
-		fs:            fs,
-		manifestPaths: manifestPaths,
-		signature:     m.pbOuter.Signature,
-		signer:        m.pbOuter.Signer,
-		signingPubKey: m.pbOuter.SigningPubKey,
+		basePath:        AbsFilePath(abs),
+		files:           files,
+		fs:              fs,
+		manifestPaths:   manifestPaths,
+		manifestRelPath: RelFilePath(manifestRel),
+		signature:       m.pbOuter.Signature,
+		signer:          m.pbOuter.Signer,
+		signingPubKey:   m.pbOuter.SigningPubKey,
 	}, nil
 }

@@ -170,6 +183,7 @@ func (c *Checker) Check(ctx context.Context, results chan<- Result, progress cha
 	var failures FileCount

 	startTime := time.Now()
+	lastProgressTime := time.Now()

 	for _, entry := range c.files {
 		select {
@@ -188,29 +202,34 @@ func (c *Checker) Check(ctx context.Context, results chan<- Result, progress cha
 			results <- result
 		}

-		// Send progress with rate and ETA calculation
+		// Send progress at most once per second (rate-limited)
 		if progress != nil {
-			elapsed := time.Since(startTime)
-			var bytesPerSec float64
-			var eta time.Duration
+			now := time.Now()
+			isLast := checkedFiles == totalFiles
+			if isLast || now.Sub(lastProgressTime) >= time.Second {
+				elapsed := time.Since(startTime)
+				var bytesPerSec float64
+				var eta time.Duration

-			if elapsed > 0 && checkedBytes > 0 {
-				bytesPerSec = float64(checkedBytes) / elapsed.Seconds()
-				remainingBytes := totalBytes - checkedBytes
-				if bytesPerSec > 0 {
-					eta = time.Duration(float64(remainingBytes)/bytesPerSec) * time.Second
+				if elapsed > 0 && checkedBytes > 0 {
+					bytesPerSec = float64(checkedBytes) / elapsed.Seconds()
+					remainingBytes := totalBytes - checkedBytes
+					if bytesPerSec > 0 {
+						eta = time.Duration(float64(remainingBytes)/bytesPerSec) * time.Second
+					}
 				}
-			}

-			sendCheckStatus(progress, CheckStatus{
-				TotalFiles:   totalFiles,
-				CheckedFiles: checkedFiles,
-				TotalBytes:   totalBytes,
-				CheckedBytes: checkedBytes,
-				BytesPerSec:  bytesPerSec,
-				ETA:          eta,
-				Failures:     failures,
-			})
+				sendCheckStatus(progress, CheckStatus{
+					TotalFiles:   totalFiles,
+					CheckedFiles: checkedFiles,
+					TotalBytes:   totalBytes,
+					CheckedBytes: checkedBytes,
+					BytesPerSec:  bytesPerSec,
+					ETA:          eta,
+					Failures:     failures,
+				})
+				lastProgressTime = now
+			}
 		}
 	}

@@ -309,14 +328,13 @@ func (c *Checker) FindExtraFiles(ctx context.Context, results chan<- Result) err
 			return nil
 		}

-		// Skip manifest files
-		base := filepath.Base(rel)
-		if base == "index.mf" || base == ".index.mf" {
+		relPath := RelFilePath(rel)
+
+		// Skip the manifest file itself
+		if relPath == c.manifestRelPath {
 			return nil
 		}

-		relPath := RelFilePath(rel)
-
 		// Check if path is in manifest
 		if _, exists := c.manifestPaths[relPath]; !exists {
 			if results != nil {