In both mfer/checker.go and internal/checker/checker.go, FindExtraFiles walks the entire directory tree and reports any file not in the manifest as "extra". However, it does not:
Skip the manifest file itself (index.mf or .index.mf) — the manifest is never included in its own file list, so it will always be reported as extra.
Skip hidden/dotfiles — when a manifest was generated without --include-dotfiles (the default), dotfiles are excluded from the manifest. FindExtraFiles will then report all dotfiles as extra, producing noisy false positives.
This makes mfer check --no-extra-files practically unusable in normal scenarios, as it will almost always fail due to the manifest file being reported as extra.
Fix:FindExtraFiles (or the CLI check command) should skip the manifest file itself, and ideally respect the same dotfile filtering that was used during generation.
In both `mfer/checker.go` and `internal/checker/checker.go`, `FindExtraFiles` walks the entire directory tree and reports any file not in the manifest as "extra". However, it does not:
1. **Skip the manifest file itself** (`index.mf` or `.index.mf`) — the manifest is never included in its own file list, so it will always be reported as extra.
2. **Skip hidden/dotfiles** — when a manifest was generated without `--include-dotfiles` (the default), dotfiles are excluded from the manifest. `FindExtraFiles` will then report all dotfiles as extra, producing noisy false positives.
This makes `mfer check --no-extra-files` practically unusable in normal scenarios, as it will almost always fail due to the manifest file being reported as extra.
**Fix:** `FindExtraFiles` (or the CLI check command) should skip the manifest file itself, and ideally respect the same dotfile filtering that was used during generation.
clawbot
self-assigned this 2026-02-08 21:01:33 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In both
mfer/checker.goandinternal/checker/checker.go,FindExtraFileswalks the entire directory tree and reports any file not in the manifest as "extra". However, it does not:index.mfor.index.mf) — the manifest is never included in its own file list, so it will always be reported as extra.--include-dotfiles(the default), dotfiles are excluded from the manifest.FindExtraFileswill then report all dotfiles as extra, producing noisy false positives.This makes
mfer check --no-extra-filespractically unusable in normal scenarios, as it will almost always fail due to the manifest file being reported as extra.Fix:
FindExtraFiles(or the CLI check command) should skip the manifest file itself, and ideally respect the same dotfile filtering that was used during generation.