sneak/lora.vegas
1
0
Fork 0
Code Issues 11 Pull Requests Actions Packages Projects Releases Wiki Activity

script/lint requires buildx; document the prerequisite #40

New Issue
Open
opened 2026-08-10 15:35:16 +02:00 by clawbot · 1 comment
clawbot commented 2026-08-10 15:35:16 +02:00
Collaborator
Copy Link
Copy Source

script/lint passes --output type=cacheonly, which is a BuildKit/buildx flag. On a docker without buildx, or with BuildKit disabled, it fails: DOCKER_BUILDKIT=0 script/lint gives unknown flag: --output, exit 125.

This is not a defect — the failure is loud and can never produce a false green, and CI is green on 25b6c0a — but the prerequisite is undocumented, so the failure is unexplained when someone hits it.

Found during review of #39 ; accepted there rather than reworked.

Why the flag is there

It avoids an image export per lint run. The main image's exporting to image step measures 121.8s, so this is a substantial saving, not the dangling-image tidiness the original commit body claims.

Definition of done

  • script/lint states buildx as a prerequisite, and states what the flag buys, in place of the weaker dangling-image rationale.
  • The README Entrypoints entry for script/lint says the same.
  • script/bootstrap is checked: decide and record whether it should verify buildx is present, or whether failing loudly at first use is sufficient. Either answer is fine; an undecided one is not.
  • make check green.
`script/lint` passes `--output type=cacheonly`, which is a BuildKit/buildx flag. On a docker without buildx, or with BuildKit disabled, it fails: `DOCKER_BUILDKIT=0 script/lint` gives `unknown flag: --output`, exit 125. This is not a defect — the failure is loud and can never produce a false green, and CI is green on `25b6c0a` — but the prerequisite is undocumented, so the failure is unexplained when someone hits it. Found during review of https://git.eeqj.de/sneak/lora.vegas/pulls/39 ; accepted there rather than reworked. ## Why the flag is there It avoids an image export per lint run. The main image's `exporting to image` step measures 121.8s, so this is a substantial saving, not the dangling-image tidiness the original commit body claims. ## Definition of done - `script/lint` states buildx as a prerequisite, and states what the flag buys, in place of the weaker dangling-image rationale. - The README Entrypoints entry for `script/lint` says the same. - `script/bootstrap` is checked: decide and record whether it should verify buildx is present, or whether failing loudly at first use is sufficient. Either answer is fine; an undecided one is not. - `make check` green.
clawbot commented 2026-10-03 14:38:18 +02:00
Author
Collaborator
Copy Link
Copy Source

State: queued, sixth of nine, not started, no branch or PR. It waits for #16 and #36, because it edits the same script/lint and README Entrypoints text.

Model: opus-5-5

State: queued, sixth of nine, not started, no branch or PR. It waits for https://git.eeqj.de/sneak/lora.vegas/issues/16 and https://git.eeqj.de/sneak/lora.vegas/issues/36, because it edits the same `script/lint` and README Entrypoints text. Model: opus-5-5
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bot
Agent's turn to work
 critical
Extremely important: data loss, a security hole, production down, or basic use impossible
 merge-ready
Review passed; ready to merge
 needs-checks
PR awaiting green checks
 needs-rebase
PR needs rebase onto main
 needs-review
PR awaiting adversarial review
 needs-rework
Review failed; PR needs rework
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/lora.vegas#40