script/lint requires buildx; document the prerequisite #40
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
script/lintpasses--output type=cacheonly, which is a BuildKit/buildx flag. On a docker without buildx, or with BuildKit disabled, it fails:DOCKER_BUILDKIT=0 script/lintgivesunknown flag: --output, exit 125.This is not a defect — the failure is loud and can never produce a false green, and CI is green on
25b6c0a— but the prerequisite is undocumented, so the failure is unexplained when someone hits it.Found during review of #39 ; accepted there rather than reworked.
Why the flag is there
It avoids an image export per lint run. The main image's
exporting to imagestep measures 121.8s, so this is a substantial saving, not the dangling-image tidiness the original commit body claims.Definition of done
script/lintstates buildx as a prerequisite, and states what the flag buys, in place of the weaker dangling-image rationale.script/lintsays the same.script/bootstrapis checked: decide and record whether it should verify buildx is present, or whether failing loudly at first use is sufficient. Either answer is fine; an undecided one is not.make checkgreen.