Two README defects found reviewing PR #35. Both pre-existing rather than
introduced there, so they were not reworked into it.
1. Getting Started clones over SSH on a public repo
The clone line uses git@git.eeqj.de:sneak/lora.vegas.git. The Gitea API
reports this repo as private: false, so an anonymous newcomer copy-pasting
that command fails — it requires a configured SSH key with access.
REPO_POLICIES.md requires Getting Started to be a "copy-pasteable
install/usage code block". A block that only works for people who already have
push access does not meet that in the sense intended.
It matches origin in a maintainer's checkout, so it may have been deliberate. If read-only public access is intended, use the HTTPS clone_url. If the
repo is meant to be effectively private in practice, say so in the README
instead of leaving a command that silently fails for everyone else.
2. Entrypoints omits two scripts
REPO_POLICIES.md: the README "must document the provided scripts in an Entrypoints section".
script/precommit and script/projectname both exist, are part of the
canonical twelve-script set, and are not listed. Every other script is.
script/projectname in particular is non-obvious — it exists so that script/docker can stay byte-identical across repos, which is worth one line
of explanation rather than leaving a reader to guess why a script exists whose
only job is to echo a string.
Definition of done
The clone command in Getting Started works for an anonymous user, or the
README states plainly that access is restricted. Verify by actually running
the clone into a temp directory without SSH credentials in play — do not
assume the URL form is sufficient.
script/precommit and script/projectname are documented in Entrypoints,
in the same style as the existing bullets.
Entrypoints lists every script in script/ — check the directory rather
than working from the current list.
make fmt run; make fmt-check passes; make check green.
TODO.md updated.
Also worth fixing while there
The Entrypoints text says the .prettierignore exclusions carry "the reason
for each"; node_modules/ and yarn.lock have no reason comment (2 of 4).
Either add reasons or soften the wording. The phrasing is copied verbatim
from script/fmt's header comment, so fix both or neither.
The newest TODO.md Completed Steps entry lacks a terminal period, unlike
its neighbours.
Out of scope
The ## License section (#10, blocked on an owner decision).
Any restructuring of the section set — #11 settled that and it passed review.
Two README defects found reviewing PR #35. Both pre-existing rather than
introduced there, so they were not reworked into it.
## 1. Getting Started clones over SSH on a public repo
The clone line uses `git@git.eeqj.de:sneak/lora.vegas.git`. The Gitea API
reports this repo as `private: false`, so an anonymous newcomer copy-pasting
that command fails — it requires a configured SSH key with access.
`REPO_POLICIES.md` requires Getting Started to be a "copy-pasteable
install/usage code block". A block that only works for people who already have
push access does not meet that in the sense intended.
It matches `origin` in a maintainer's checkout, so it may have been deliberate.
**If read-only public access is intended, use the HTTPS `clone_url`.** If the
repo is meant to be effectively private in practice, say so in the README
instead of leaving a command that silently fails for everyone else.
## 2. Entrypoints omits two scripts
`REPO_POLICIES.md`: the README "must document the provided scripts in an
**Entrypoints** section".
`script/precommit` and `script/projectname` both exist, are part of the
canonical twelve-script set, and are not listed. Every other script is.
`script/projectname` in particular is non-obvious — it exists so that
`script/docker` can stay byte-identical across repos, which is worth one line
of explanation rather than leaving a reader to guess why a script exists whose
only job is to echo a string.
## Definition of done
1. The clone command in Getting Started works for an anonymous user, or the
README states plainly that access is restricted. Verify by actually running
the clone into a temp directory without SSH credentials in play — do not
assume the URL form is sufficient.
2. `script/precommit` and `script/projectname` are documented in Entrypoints,
in the same style as the existing bullets.
3. Entrypoints lists every script in `script/` — check the directory rather
than working from the current list.
4. `make fmt` run; `make fmt-check` passes; `make check` green.
5. `TODO.md` updated.
## Also worth fixing while there
- The Entrypoints text says the `.prettierignore` exclusions carry "the reason
for each"; `node_modules/` and `yarn.lock` have no reason comment (2 of 4).
Either add reasons or soften the wording. The phrasing is copied verbatim
from `script/fmt`'s header comment, so fix both or neither.
- The newest `TODO.md` Completed Steps entry lacks a terminal period, unlike
its neighbours.
## Out of scope
- The `## License` section (#10, blocked on an owner decision).
- Any restructuring of the section set — #11 settled that and it passed review.
Plan: one PR, branched from next, with next as its base.
Getting Started clones over HTTPS: the API reports the repo as public, so https://git.eeqj.de/sneak/lora.vegas.git is the answer and the "restricted access" alternative does not apply. Prove it with a real clone into a temp directory with no SSH key in play. Keep the existing "contact sneak for push access" sentence.
Entrypoints lists every file in script/ (currently twelve), adding script/precommit and script/projectname in the existing bullet style. Give script/projectname one line on why it exists: it lets script/docker stay identical across repos.
Fix the .prettierignore wording in both the README and the script/fmt header comment, either by adding the missing reasons for node_modules/ and yarn.lock or by softening "the reason for each". Keep the two consistent.
Add the missing final period to the newest TODO.md Completed Steps entry, and update TODO.md for this unit.
The issue's "Out of scope" note about the License section is stale (that work is merged); ignore it.
Model: opus-5-5
Plan: one PR, branched from `next`, with `next` as its base.
- Getting Started clones over HTTPS: the API reports the repo as public, so `https://git.eeqj.de/sneak/lora.vegas.git` is the answer and the "restricted access" alternative does not apply. Prove it with a real clone into a temp directory with no SSH key in play. Keep the existing "contact sneak for push access" sentence.
- Entrypoints lists every file in `script/` (currently twelve), adding `script/precommit` and `script/projectname` in the existing bullet style. Give `script/projectname` one line on why it exists: it lets `script/docker` stay identical across repos.
- Fix the `.prettierignore` wording in both the README and the `script/fmt` header comment, either by adding the missing reasons for `node_modules/` and `yarn.lock` or by softening "the reason for each". Keep the two consistent.
- Add the missing final period to the newest `TODO.md` Completed Steps entry, and update `TODO.md` for this unit.
- The issue's "Out of scope" note about the License section is stale (that work is merged); ignore it.
Model: opus-5-5
State: queued, first in this repo's backlog of nine. Its worker was stopped before it pushed anything, so there is no branch or PR. Relaunch it as written in the plan comment above. It touches README.md, TODO.md and the script/fmt header comment, and can run alongside #16, #42 and #28.
Model: opus-5-5
State: queued, first in this repo's backlog of nine. Its worker was stopped before it pushed anything, so there is no branch or PR. Relaunch it as written in the plan comment above. It touches README.md, TODO.md and the `script/fmt` header comment, and can run alongside https://git.eeqj.de/sneak/lora.vegas/issues/16, https://git.eeqj.de/sneak/lora.vegas/issues/42 and https://git.eeqj.de/sneak/lora.vegas/issues/28.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Two README defects found reviewing PR #35. Both pre-existing rather than
introduced there, so they were not reworked into it.
1. Getting Started clones over SSH on a public repo
The clone line uses
git@git.eeqj.de:sneak/lora.vegas.git. The Gitea APIreports this repo as
private: false, so an anonymous newcomer copy-pastingthat command fails — it requires a configured SSH key with access.
REPO_POLICIES.mdrequires Getting Started to be a "copy-pasteableinstall/usage code block". A block that only works for people who already have
push access does not meet that in the sense intended.
It matches
originin a maintainer's checkout, so it may have been deliberate.If read-only public access is intended, use the HTTPS
clone_url. If therepo is meant to be effectively private in practice, say so in the README
instead of leaving a command that silently fails for everyone else.
2. Entrypoints omits two scripts
REPO_POLICIES.md: the README "must document the provided scripts in anEntrypoints section".
script/precommitandscript/projectnameboth exist, are part of thecanonical twelve-script set, and are not listed. Every other script is.
script/projectnamein particular is non-obvious — it exists so thatscript/dockercan stay byte-identical across repos, which is worth one lineof explanation rather than leaving a reader to guess why a script exists whose
only job is to echo a string.
Definition of done
README states plainly that access is restricted. Verify by actually running
the clone into a temp directory without SSH credentials in play — do not
assume the URL form is sufficient.
script/precommitandscript/projectnameare documented in Entrypoints,in the same style as the existing bullets.
script/— check the directory ratherthan working from the current list.
make fmtrun;make fmt-checkpasses;make checkgreen.TODO.mdupdated.Also worth fixing while there
.prettierignoreexclusions carry "the reasonfor each";
node_modules/andyarn.lockhave no reason comment (2 of 4).Either add reasons or soften the wording. The phrasing is copied verbatim
from
script/fmt's header comment, so fix both or neither.TODO.mdCompleted Steps entry lacks a terminal period, unlikeits neighbours.
Out of scope
## Licensesection (#10, blocked on an owner decision).Plan: one PR, branched from
next, withnextas its base.https://git.eeqj.de/sneak/lora.vegas.gitis the answer and the "restricted access" alternative does not apply. Prove it with a real clone into a temp directory with no SSH key in play. Keep the existing "contact sneak for push access" sentence.script/(currently twelve), addingscript/precommitandscript/projectnamein the existing bullet style. Givescript/projectnameone line on why it exists: it letsscript/dockerstay identical across repos..prettierignorewording in both the README and thescript/fmtheader comment, either by adding the missing reasons fornode_modules/andyarn.lockor by softening "the reason for each". Keep the two consistent.TODO.mdCompleted Steps entry, and updateTODO.mdfor this unit.Model: opus-5-5
State: queued, first in this repo's backlog of nine. Its worker was stopped before it pushed anything, so there is no branch or PR. Relaunch it as written in the plan comment above. It touches README.md, TODO.md and the
script/fmtheader comment, and can run alongside #16, #42 and #28.Model: opus-5-5