Require secret at the commit that drops go-bip39 #71

Merged
clawbot merged 1 commits from issue-70-drop-bip39-sum into next 2026-10-07 13:43:38 +02:00
Collaborator

Closes #70.

keyfunc now requires sneak/secret at ef0ae90, the commit from sneak/secret#130 that gives secret its own copy of go-bip39. Nothing keyfunc builds or tests imports go-bip39 any more, so go mod tidy removes its two go.sum lines. No other requirement in go.mod moves.

What the diff does not show: secret renamed its module from git.eeqj.de/sneak/secret to sneak.berlin/go/secret (sneak/secret#43) before that commit. Every secret commit without go-bip39 has the new name. So the requirement uses the new path, the imports of its pkg/bip85 in internal/derive and internal/childmnemonic move with it, and the README sentence naming that package gives the new path. Between the old and new commits, pkg/bip85 changed only in its two password functions, which keyfunc does not call. No test or vector changes.

  • Deviation: the brief asked only to raise the git.eeqj.de/sneak/secret requirement. The rename made that impossible, so the requirement, two import lines and one README sentence change path.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/keyfunc/issues/70. keyfunc now requires `sneak/secret` at `ef0ae90`, the commit from https://git.eeqj.de/sneak/secret/pulls/130 that gives `secret` its own copy of go-bip39. Nothing keyfunc builds or tests imports go-bip39 any more, so `go mod tidy` removes its two `go.sum` lines. No other requirement in `go.mod` moves. What the diff does not show: `secret` renamed its module from `git.eeqj.de/sneak/secret` to `sneak.berlin/go/secret` (https://git.eeqj.de/sneak/secret/issues/43) before that commit. Every `secret` commit without go-bip39 has the new name. So the requirement uses the new path, the imports of its `pkg/bip85` in `internal/derive` and `internal/childmnemonic` move with it, and the README sentence naming that package gives the new path. Between the old and new commits, `pkg/bip85` changed only in its two password functions, which keyfunc does not call. No test or vector changes. - Deviation: the brief asked only to raise the `git.eeqj.de/sneak/secret` requirement. The rename made that impossible, so the requirement, two import lines and one README sentence change path. Model: opus-5-5
clawbot added the needs-review label 2026-10-07 13:11:21 +02:00
clawbot self-assigned this 2026-10-07 13:11:21 +02:00
clawbot added 1 commit 2026-10-07 13:11:22 +02:00
sneak/secret now carries its own copy of go-bip39
(sneak/secret#130), so requiring it at that
commit, ef0ae90, lets go mod tidy drop go-bip39 from go.sum. Earlier,
secret renamed its module to sneak.berlin/go/secret
(sneak/secret#43), so the requirement, the
two imports of its bip85 package and the README sentence naming that
package move to the new path. The bip85 functions keyfunc calls are
unchanged, and no other requirement moves.

Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit 45463fa35b into next 2026-10-07 13:43:38 +02:00
clawbot deleted branch issue-70-drop-bip39-sum 2026-10-07 13:43:38 +02:00
Sign in to join this conversation.