Drop go-bip39 from go.sum once sneak/secret no longer imports it #70

Closed
opened 2026-10-07 11:27:11 +02:00 by clawbot · 1 comment
Collaborator

Since #69 nothing in keyfunc imports github.com/tyler-smith/go-bip39, but go mod tidy keeps its two go.sum lines: the test of sneak/secret's pkg/bip85, which keyfunc imports, still imports it. sneak has ruled that secret copies it in as well (sneak/secret#122); this issue follows once that lands.

Waits on: the sneak/secret PR that closes sneak/secret#122, merged to secret's next.

Plan

  • Raise keyfunc's git.eeqj.de/sneak/secret requirement to the commit that lands that copy (its squash commit on secret's next), and let go mod tidy settle go.mod and go.sum (script/precommit checks it).
  • Nothing else changes. If the newer secret also changes pkg/bip85, every existing test passes unchanged, the README's vectors included. Any other requirement that tidy moves is disclosed in one line in the PR.

Definition of done

  • No line of go.mod or go.sum names github.com/tyler-smith/go-bip39.
  • Every existing test vector is unchanged; make check passes.
  • Branch cut from next, one PR to next that closes this issue.

Model: opus-5-5

Since https://git.eeqj.de/sneak/keyfunc/pulls/69 nothing in keyfunc imports `github.com/tyler-smith/go-bip39`, but `go mod tidy` keeps its two `go.sum` lines: the test of `sneak/secret`'s `pkg/bip85`, which keyfunc imports, still imports it. sneak has ruled that `secret` copies it in as well (https://git.eeqj.de/sneak/secret/issues/122); this issue follows once that lands. **Waits on:** the `sneak/secret` PR that closes https://git.eeqj.de/sneak/secret/issues/122, merged to `secret`'s `next`. ## Plan - Raise keyfunc's `git.eeqj.de/sneak/secret` requirement to the commit that lands that copy (its squash commit on `secret`'s `next`), and let `go mod tidy` settle `go.mod` and `go.sum` (`script/precommit` checks it). - Nothing else changes. If the newer `secret` also changes `pkg/bip85`, every existing test passes unchanged, the README's vectors included. Any other requirement that tidy moves is disclosed in one line in the PR. ## Definition of done - No line of `go.mod` or `go.sum` names `github.com/tyler-smith/go-bip39`. - Every existing test vector is unchanged; `make check` passes. - Branch cut from `next`, one PR to `next` that closes this issue. Model: opus-5-5
clawbot self-assigned this 2026-10-07 11:27:11 +02:00
Author
Collaborator

#71 requires secret at ef0ae90, and go-bip39 leaves go.sum. secret had already renamed its module to sneak.berlin/go/secret (sneak/secret#43), so keyfunc's requirement, its two imports of pkg/bip85 and the README sentence naming that package now use the new path. No test or vector changes.

Model: opus-5-5

https://git.eeqj.de/sneak/keyfunc/pulls/71 requires `secret` at `ef0ae90`, and go-bip39 leaves `go.sum`. `secret` had already renamed its module to `sneak.berlin/go/secret` (https://git.eeqj.de/sneak/secret/issues/43), so keyfunc's requirement, its two imports of `pkg/bip85` and the README sentence naming that package now use the new path. No test or vector changes. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/keyfunc#70