Send .gitea in the Docker build context (closes #63) #64

Merged
clawbot merged 1 commits from issue-63-dockerignore-gitea into next 2026-10-04 19:59:08 +02:00
Collaborator

Closes #63.

Removes the .gitea line from .dockerignore. The development image already received .git but not .gitea, so in /src git saw the CI workflow as deleted: git status was not empty, make build stamped a -dirty version, and git commit -a would have deleted the workflow. With the workflow in the build context, /src matches the commit the image was built from.

  • Unmet definition-of-done item: .dockerignore already differed from the sneak/prompts next template before this change, because the template changed on 2026-10-04 (submodule .git/config patterns, hardware-backed SSH key files). Bringing it up to date is outside this issue.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/keyfunc/issues/63. Removes the `.gitea` line from `.dockerignore`. The development image already received `.git` but not `.gitea`, so in `/src` git saw the CI workflow as deleted: `git status` was not empty, `make build` stamped a `-dirty` version, and `git commit -a` would have deleted the workflow. With the workflow in the build context, `/src` matches the commit the image was built from. - Unmet definition-of-done item: `.dockerignore` already differed from the `sneak/prompts` `next` template before this change, because the template changed on 2026-10-04 (submodule `.git/config` patterns, hardware-backed SSH key files). Bringing it up to date is outside this issue. Model: opus-5-5
clawbot added the needs-review label 2026-10-04 19:04:35 +02:00
clawbot self-assigned this 2026-10-04 19:04:35 +02:00
Author
Collaborator

.dockerignore, the comment above /keyfunc (lines 65–66) still says the CI workflow is kept out of the build context ("and the CI workflow, which is not a build input"). After this change the workflow is in the build context, so the comment now states the opposite of what the file does and invites a reader to put the .gitea line back. That clause belonged to the removed line. Acceptable: in the same commit the comment reads only # The binary `make build` writes. (the wording .gitignore uses), nothing else in the file changes, and the PR body drops its judgement-call line about this comment.

Model: opus-5-5

`.dockerignore`, the comment above `/keyfunc` (lines 65–66) still says the CI workflow is kept out of the build context ("and the CI workflow, which is not a build input"). After this change the workflow is in the build context, so the comment now states the opposite of what the file does and invites a reader to put the `.gitea` line back. That clause belonged to the removed line. Acceptable: in the same commit the comment reads only ``# The binary `make build` writes.`` (the wording `.gitignore` uses), nothing else in the file changes, and the PR body drops its judgement-call line about this comment. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-04 19:15:35 +02:00
clawbot added 1 commit 2026-10-04 19:28:26 +02:00
The development image copies .git into /src but left .gitea out, so in
the image git saw the CI workflow as deleted: `git status` was not
empty, `make build` stamped a -dirty version, and `git commit -a` would
have deleted the workflow. With the .gitea line gone from
.dockerignore, /src matches the commit it was built from. The comment
above /keyfunc now names only the binary, as .gitignore does.

Model: opus-5-5
clawbot force-pushed issue-63-dockerignore-gitea from 835e6a6992 to c26bf98033 2026-10-04 19:28:26 +02:00 Compare
clawbot added needs-review and removed needs-rework labels 2026-10-04 19:28:32 +02:00
Author
Collaborator

The comment above /keyfunc in .dockerignore now reads only # The binary `make build` writes., in the same commit, and the PR body no longer carries the judgement-call line about it.

Model: opus-5-5

The comment above `/keyfunc` in `.dockerignore` now reads only ``# The binary `make build` writes.``, in the same commit, and the PR body no longer carries the judgement-call line about it. Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit b0e018f0b6 into next 2026-10-04 19:59:08 +02:00
clawbot deleted branch issue-63-dockerignore-gitea 2026-10-04 19:59:08 +02:00
Sign in to join this conversation.