From the fourth whole-branch review of #28 (#28 (comment)), finding 1:
The development image's /src is not a clean checkout. .dockerignore carries keyfunc's own .gitea line, so the image gets .git but not .gitea: in it git status reports .gitea/workflows/check.yml as deleted, make build stamps a -dirty version, and git commit -a would delete the CI workflow. The README says the image holds the source tree in /src.
Work, on a branch cut from next, PR to next: remove the .gitea line from .dockerignore; nothing else changes.
Definition of done
In /src of an image built with a plain docker build . from a fresh clone, git status is empty and make build stamps the short commit without -dirty.
.dockerignore still equals the sneak/promptsnext template plus keyfunc's own lines.
make check passes.
Model: opus-5-5
From the fourth whole-branch review of https://git.eeqj.de/sneak/keyfunc/pulls/28 (https://git.eeqj.de/sneak/keyfunc/pulls/28#issuecomment-124779), finding 1:
The development image's `/src` is not a clean checkout. `.dockerignore` carries keyfunc's own `.gitea` line, so the image gets `.git` but not `.gitea`: in it `git status` reports `.gitea/workflows/check.yml` as deleted, `make build` stamps a `-dirty` version, and `git commit -a` would delete the CI workflow. The README says the image holds the source tree in `/src`.
Work, on a branch cut from `next`, PR to `next`: remove the `.gitea` line from `.dockerignore`; nothing else changes.
## Definition of done
- In `/src` of an image built with a plain `docker build .` from a fresh clone, `git status` is empty and `make build` stamps the short commit without `-dirty`.
- `.dockerignore` still equals the `sneak/prompts` `next` template plus keyfunc's own lines.
- `make check` passes.
Model: opus-5-5
clawbot
self-assigned this 2026-10-04 18:59:08 +02:00
Removed the .gitea line from .dockerignore in #64; its body lists two disclosures (a comment that still names the CI workflow, and the template having moved ahead of this file).
Model: opus-5-5
Removed the `.gitea` line from `.dockerignore` in https://git.eeqj.de/sneak/keyfunc/pulls/64; its body lists two disclosures (a comment that still names the CI workflow, and the template having moved ahead of this file).
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
From the fourth whole-branch review of #28 (#28 (comment)), finding 1:
The development image's
/srcis not a clean checkout..dockerignorecarries keyfunc's own.gitealine, so the image gets.gitbut not.gitea: in itgit statusreports.gitea/workflows/check.ymlas deleted,make buildstamps a-dirtyversion, andgit commit -awould delete the CI workflow. The README says the image holds the source tree in/src.Work, on a branch cut from
next, PR tonext: remove the.gitealine from.dockerignore; nothing else changes.Definition of done
/srcof an image built with a plaindocker build .from a fresh clone,git statusis empty andmake buildstamps the short commit without-dirty..dockerignorestill equals thesneak/promptsnexttemplate plus keyfunc's own lines.make checkpasses.Model: opus-5-5
Removed the
.gitealine from.dockerignorein #64; its body lists two disclosures (a comment that still names the CI workflow, and the template having moved ahead of this file).Model: opus-5-5