sneak/dnswatcher
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

docs: document the no-DNS-mocking policy in README (closes #94) #95

Merged
sneak merged 1 commits from docs/no-dns-mocking-readme into main 2026-08-07 22:31:48 +02:00
Conversation 0 Commits 1 Files Changed 1 +20
clawbot commented 2026-08-07 18:27:30 +02:00
Collaborator
Copy Link

Adds a prominent "No DNS mocking. Ever." section near the top of README.md, per owner policy (sneak, 2026-08-07):

  • DNS is never mocked in this project — no mock resolvers, fake DNS servers, or stubbed lookups, in tests or anywhere else.
  • Tests exercise real iterative resolution against live nameservers by design.
  • Flaky live tests are fixed with robustness (retries, multiple nameservers, timeouts) or explicit opt-in gating decided by the owner — never with mocks.
  • Contributions introducing DNS mocks will be rejected.

Markdown-only change; matches the README's existing tone and hard-wrap style. script/fmt covers Go only, so no formatter output applies to this file. Verified via script/cibuild (docker build runs make check with the pinned toolchain) — green. A direct local make check shows 21 pre-existing goconst lint findings that come from a newer local golangci-lint (v2.12.2 vs the pinned v2.10.1) and are unrelated to this change.

Related: #93 is being reframed under this policy.

Adds a prominent "No DNS mocking. Ever." section near the top of `README.md`, per owner policy (sneak, 2026-08-07): - DNS is never mocked in this project — no mock resolvers, fake DNS servers, or stubbed lookups, in tests or anywhere else. - Tests exercise real iterative resolution against live nameservers by design. - Flaky live tests are fixed with robustness (retries, multiple nameservers, timeouts) or explicit opt-in gating decided by the owner — never with mocks. - Contributions introducing DNS mocks will be rejected. Markdown-only change; matches the README's existing tone and hard-wrap style. `script/fmt` covers Go only, so no formatter output applies to this file. Verified via `script/cibuild` (docker build runs `make check` with the pinned toolchain) — green. A direct local `make check` shows 21 pre-existing `goconst` lint findings that come from a newer local `golangci-lint` (v2.12.2 vs the pinned v2.10.1) and are unrelated to this change. Related: #93 is being reframed under this policy.
clawbot added 1 commit 2026-08-07 18:27:30 +02:00
docs: document the no-DNS-mocking policy in README (closes #94)
All checks were successful
check / check (push) Successful in 4s
Details
0e13d85089 
DNS is never mocked in dnswatcher — not in tests, not anywhere.
Tests run against the real DNS by design; flaky live tests get
fixed with robustness or owner-decided opt-in gating, never mocks.
Record this prominently near the top of the README so contributors
and future workers do not propose mocked resolvers.
clawbot added the needs-review label 2026-08-07 18:27:35 +02:00
clawbot self-assigned this 2026-08-07 18:27:35 +02:00
clawbot added merge-ready and removed needs-review labels 2026-08-07 22:09:24 +02:00
clawbot removed their assignment 2026-08-07 22:09:25 +02:00
sneak was assigned by clawbot 2026-08-07 22:09:25 +02:00
sneak merged commit f79cd98107 into main 2026-08-07 22:31:48 +02:00
sneak deleted branch docs/no-dns-mocking-readme 2026-08-07 22:31:48 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label merge-ready
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#95
Delete Branch "docs/no-dns-mocking-readme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?