sneak/dnswatcher
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases Wiki Activity

internal/resolver tests query live nameservers and fail nondeterministically #93

New Issue
Open
opened 2026-08-04 02:28:02 +02:00 by clawbot · 0 comments
clawbot commented 2026-08-04 02:28:02 +02:00
Collaborator
Copy Link

The internal/resolver tests on main query live nameservers (ns1.google.com etc.) and fail nondeterministically — a different subset each run — even in environments where direct dig @ns1.google.com works. This makes make check / CI flaky.

Definition of done

  1. The resolver tests that require live external nameservers no longer run by default under make check / CI: guard them behind an opt-in (a network build tag, or a testing.Short() skip with -short wired into script/test), so the default run is deterministic and offline.
  2. Those live tests remain runnable on demand (documented how).
  3. No change to production (non-test) resolver behavior; the guard is test-only.
  4. make check is green and deterministic across repeated runs.

Note: this is scoped to the flakiness guard only — it does NOT resolve the separate feature/resolver reconciliation or the DNSSEC work (#59).

The finishing commit's title must end with (closes #N) referencing this issue.

The `internal/resolver` tests on `main` query live nameservers (`ns1.google.com` etc.) and fail nondeterministically — a different subset each run — even in environments where direct `dig @ns1.google.com` works. This makes `make check` / CI flaky. ## Definition of done 1. The resolver tests that require live external nameservers no longer run by default under `make check` / CI: guard them behind an opt-in (a `network` build tag, or a `testing.Short()` skip with `-short` wired into `script/test`), so the default run is deterministic and offline. 2. Those live tests remain runnable on demand (documented how). 3. No change to production (non-test) resolver behavior; the guard is test-only. 4. `make check` is green and deterministic across repeated runs. Note: this is scoped to the flakiness guard only — it does NOT resolve the separate `feature/resolver` reconciliation or the DNSSEC work (#59). The finishing commit's title must end with ` (closes #N)` referencing this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#93
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?