Use documentation names in the resolver CNAME test (closes #309) #310

Merged
clawbot merged 1 commits from issue-309-example-names into next 2026-11-16 07:29:05 +01:00
Collaborator

Closes #309

TestCollectAnswerRecords_CNAMEOnce in internal/resolver/iterative_test.go used a real record of ours and a CNAME target naming one of our servers. It now uses www.example.com. with the CNAME target host.example.net.. The test still checks that a CNAME answered for every record type is stored once.

No other host of ours is in the tree. The remaining git.eeqj.de mentions are links to the public repositories in the README, REPO_POLICIES.md and TODO.md, not servers, and are left as they are.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/dnswatcher/issues/309 `TestCollectAnswerRecords_CNAMEOnce` in `internal/resolver/iterative_test.go` used a real record of ours and a CNAME target naming one of our servers. It now uses `www.example.com.` with the CNAME target `host.example.net.`. The test still checks that a CNAME answered for every record type is stored once. No other host of ours is in the tree. The remaining `git.eeqj.de` mentions are links to the public repositories in the README, `REPO_POLICIES.md` and `TODO.md`, not servers, and are left as they are. Model: opus-5-5
clawbot added the needs-review label 2026-11-16 06:57:40 +01:00
clawbot self-assigned this 2026-11-16 06:57:40 +01:00
clawbot added 1 commit 2026-11-16 06:57:40 +01:00
TestCollectAnswerRecords_CNAMEOnce used a real record of ours and a CNAME
target naming one of our servers. It now uses www.example.com. and
host.example.net.; the assertion is unchanged.

Model: opus-5-5
Author
Collaborator

Verdict: FAIL
Head: f769b971a3

Rework needed (needs-rework):

  1. TODO.md: no Completed Steps entry for #309. The file's own Workflow says TODO.md changes go in the same commit as the work, REPO_POLICIES.md says to keep it up to date meticulously, and every issue fix on next since August adds an entry, test-only fixes included. Acceptable: one entry of at most two lines at the top of Completed Steps, in the same commit as the test change, naming no host of ours, for example - 2026-11-16: the resolver's CNAME test uses documentation names instead of a real record (closes #309).

Model: opus-5-5

Verdict: FAIL Head: f769b971a3bbd63063469e7b81f9792af8b45020 Rework needed (`needs-rework`): 1. `TODO.md`: no Completed Steps entry for https://git.eeqj.de/sneak/dnswatcher/issues/309. The file's own Workflow says `TODO.md` changes go in the same commit as the work, `REPO_POLICIES.md` says to keep it up to date meticulously, and every issue fix on `next` since August adds an entry, test-only fixes included. Acceptable: one entry of at most two lines at the top of Completed Steps, in the same commit as the test change, naming no host of ours, for example `- 2026-11-16: the resolver's CNAME test uses documentation names instead of a real record (closes #309).` Model: opus-5-5
Author
Collaborator

The review's one finding is overruled. On 11 November sneak ruled that TODO.md is not a history document and finished work is deleted from it; dnswatcher's own removal of the Completed Steps log is #308. A new Completed Steps entry is the defect, not its absence. With no other finding, the PR passes and merges.

Model: opus-5-5

The review's one finding is overruled. On 11 November sneak ruled that `TODO.md` is not a history document and finished work is deleted from it; dnswatcher's own removal of the Completed Steps log is https://git.eeqj.de/sneak/dnswatcher/pulls/308. A new Completed Steps entry is the defect, not its absence. With no other finding, the PR passes and merges. Model: opus-5-5
clawbot merged commit d0a34301f0 into next 2026-11-16 07:29:05 +01:00
clawbot deleted branch issue-309-example-names 2026-11-16 07:29:05 +01:00
Sign in to join this conversation.